From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Sergio Gonzalez Monroy
<sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] Pass verbose flag to kernel module
Date: Wed, 08 Oct 2014 19:05:32 +0200 [thread overview]
Message-ID: <1731940.NUuDDJsRCL@xps13> (raw)
In-Reply-To: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hi Sergio,
2014-10-06 17:09, Sergio Gonzalez Monroy:
> --- a/mk/rte.module.mk
> +++ b/mk/rte.module.mk
> @@ -78,7 +78,7 @@ build: _postbuild
> $(MODULE).ko: $(SRCS_LINKS)
> @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
> - CROSS_COMPILE=$(CROSS)
> + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)
Please could you explain why it is needed?
The variable V should be inherited by the recursive make.
It's working without your patch in my test.
--
Thomas
next prev parent reply other threads:[~2014-10-08 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 16:09 [PATCH] Pass verbose flag to kernel module Sergio Gonzalez Monroy
[not found] ` <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-08 17:05 ` Thomas Monjalon [this message]
2014-10-09 9:37 ` Sergio Gonzalez Monroy
[not found] ` <20141009093713.GB23978-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
2014-10-09 12:15 ` Thomas Monjalon
2014-10-13 16:08 ` De Lara Guarch, Pablo
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972262B7FB-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-15 12:04 ` Thomas Monjalon
2014-10-15 13:05 ` Gonzalez Monroy, Sergio
2014-10-15 13:08 ` [PATCH] Set V=1 when building kernel modules Sergio Gonzalez Monroy
[not found] ` <1413378491-15573-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-15 13:43 ` Gonzalez Monroy, Sergio
2014-10-15 13:08 ` [PATCH v2] " Sergio Gonzalez Monroy
[not found] ` <1413378534-15626-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-15 14:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1731940.NUuDDJsRCL@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.