From: Valdis.Kletnieks@vt.edu
To: Youquan Song <youquan.song@linux.intel.com>
Cc: Youquan Song <youquan.song@intel.com>,
linux-kernel@vger.kernel.org, david.woodhouse@intel.com,
akpm@linux-foundation.org, mingo@elte.hu, tglx@linutronix.de,
hpa@zytor.com, hpa@linux.intel.com, allen.m.kay@intel.com,
suresh.b.siddha@intel.com, rajesh.sankaran@intel.com,
asit.k.mallick@intel.com, kent.liu@intel.com
Subject: Re: [PATCH v3] x86, vt-d: enable x2apic opt out
Date: Tue, 24 May 2011 00:18:06 -0400 [thread overview]
Message-ID: <17321.1306210686@localhost> (raw)
In-Reply-To: Your message of "Tue, 24 May 2011 11:36:14 EDT." <20110524153614.GA19080@linux-youquan.bj.intel.com>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Tue, 24 May 2011 11:36:14 EDT, Youquan Song said:
> > If we're doing a WARN level here, what are the downsides of just automagically
> > forcing it rather than making them use a kernel parameter and reboot?
>
> As we have discussed before, x2apci opt out feature is requested from OEM that
> they want to firmware tell OS to opt out x2apic when the platform,
> hardware or BIOS is not ready to support x2apic. So we can not reboot or
> force to use kernel parameter.
Do we want an actual WARN there, complete with stack traceback and all?
Or did you intend a pr_warn or printk(KERN_WARNING or similar?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-05-24 4:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 14:32 [PATCH v3] x86, vt-d: enable x2apic opt out Youquan Song
2011-05-24 2:18 ` Valdis.Kletnieks
2011-05-24 15:36 ` Youquan Song
2011-05-24 4:18 ` Valdis.Kletnieks [this message]
2011-05-24 7:38 ` David Woodhouse
2011-05-24 12:13 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17321.1306210686@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=allen.m.kay@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=david.woodhouse@intel.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kent.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rajesh.sankaran@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.