From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] buildtools: fix build for some mktemp
Date: Fri, 26 Oct 2018 21:59:46 +0200 [thread overview]
Message-ID: <1732780.omknZ3gl4j@xps> (raw)
In-Reply-To: <bea68a1b-e4f0-d6a9-8f68-ae3a09f982f8@intel.com>
26/10/2018 20:31, Ferruh Yigit:
> On 10/26/2018 6:59 PM, Thomas Monjalon wrote:
> > 26/10/2018 20:42, Ferruh Yigit:
> >> build error:
> >> == Build drivers/net/tap
> >> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
> >> Invalid argument
> >> .../buildtools/auto-config-h.sh: line 86: : No such file or directory
> >> .../drivers/net/tap/Makefile:55: recipe for target
> >> 'tap_autoconf.h.new' failed
> >>
> >> Above error observed on Wind River Linux 8.0
> >>
> >> `mktemp` command in that system has a restrictions to have X in
> >> the template at the end and at least six of them.
> >
> > So let's comply with this requirement.
>
> We can't directly, because that temp file needs to be a .c file.
The .c extension is mandatory?
> What can be done is create a temp file via mktemp and append .c later:
> _temp=$(mktemp -t dpdk.${0##*/}.XXXXXX)
> temp=${_temp}.c
>
> Do we need this?
Yes I think it's better.
> >> Switched back to static assignment for `temp` in buildtools,
> >> but kept `dpdk.` prefix to preserve the common prefix intention.
> >
> > It is a regression.
> > mktemp allows to choose the temporary directory thanks to TMPDIR
> > environment variable.
next prev parent reply other threads:[~2018-10-26 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 18:42 [PATCH] buildtools: fix build for some mktemp Ferruh Yigit
2018-10-26 17:59 ` Thomas Monjalon
2018-10-26 18:31 ` Ferruh Yigit
2018-10-26 19:59 ` Thomas Monjalon [this message]
2018-10-26 23:28 ` Ferruh Yigit
2018-10-27 0:38 ` [PATCH v2] " Ferruh Yigit
2018-10-26 23:47 ` Thomas Monjalon
2018-10-26 23:53 ` Ferruh Yigit
2018-10-27 0:05 ` Thomas Monjalon
2018-10-27 13:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732780.omknZ3gl4j@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.