All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, Andre Muezerie <andremue@linux.microsoft.com>
Subject: [PATCH] lib/fib: remove warning about implicit 64-bit conversion
Date: Tue,  3 Dec 2024 18:56:50 -0800	[thread overview]
Message-ID: <1733281010-23780-1-git-send-email-andremue@linux.microsoft.com> (raw)

MSVC issues the warning below:

../lib/fib/trie.c(341): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

The fix is to cast the result explicitly to ptrdiff_t since it is used
in pointer arithmetic.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 lib/fib/trie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/fib/trie.c b/lib/fib/trie.c
index 4893f6c636..997b7cc338 100644
--- a/lib/fib/trie.c
+++ b/lib/fib/trie.c
@@ -338,7 +338,7 @@ write_edge(struct rte_trie_tbl *dp, const uint8_t *ip_part, uint64_t next_hop,
 		if (ret < 0)
 			return ret;
 		if (edge == LEDGE) {
-			write_to_dp((uint8_t *)p + (1 << dp->nh_sz),
+			write_to_dp((uint8_t *)p + (ptrdiff_t)(1 << dp->nh_sz),
 				next_hop << 1, dp->nh_sz, UINT8_MAX - *ip_part);
 		} else {
 			write_to_dp(get_tbl_p_by_idx(dp->tbl8, tbl8_idx *
-- 
2.47.0.vfs.0.3


             reply	other threads:[~2024-12-04  2:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04  2:56 Andre Muezerie [this message]
2024-12-04 22:59 ` [PATCH] lib/fib: remove warning about implicit 64-bit conversion Stephen Hemminger
2024-12-05 15:34   ` Andre Muezerie
2024-12-05 15:38 ` [PATCH v2] " Andre Muezerie
2025-03-03 22:54 ` [PATCH v3] " Andre Muezerie
2025-03-04  6:49   ` Stephen Hemminger
2025-03-04 16:51     ` Andre Muezerie
2025-03-04 10:47   ` Bruce Richardson
2025-03-04 16:52     ` Andre Muezerie
2025-03-04 16:48 ` [PATCH v4] " Andre Muezerie
2025-05-16 20:45 ` [PATCH v5 0/2] enable fib to be compiled with MSVC Andre Muezerie
2025-05-16 20:45   ` [PATCH v5 1/2] lib/fib: remove warning about implicit 64-bit conversion Andre Muezerie
2025-05-17 10:07     ` Morten Brørup
2025-05-17 11:09     ` Stephen Hemminger
2025-05-17 12:59       ` Morten Brørup
2025-05-16 20:45   ` [PATCH v5 2/2] lib/fib: enable fib to be compiled with MSVC Andre Muezerie
2025-06-03 14:33   ` [PATCH v5 0/2] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1733281010-23780-1-git-send-email-andremue@linux.microsoft.com \
    --to=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.