From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Thu, 19 Apr 2018 14:09:52 +0300 Message-ID: <1733412.i2Wslp7VkI@avalon> References: <20180410051927.8268-1-philippe.cornu@st.com> <20599695.GSkeUvMnvx@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philippe CORNU Cc: Mark Rutland , "devicetree@vger.kernel.org" , Alexandre TORGUE , David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Yannick FERTRE , Rob Herring List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcGUsCgpPbiBUaHVyc2RheSwgMTkgQXByaWwgMjAxOCAxMjozMToxNSBFRVNUIFBo aWxpcHBlIENPUk5VIHdyb3RlOgo+IE9uIDA0LzE5LzIwMTggMTA6MTEgQU0sIExhdXJlbnQgUGlu Y2hhcnQgd3JvdGU6Cj4gPiBPbiBUdWVzZGF5LCAxMCBBcHJpbCAyMDE4IDA4OjE5OjI2IEVFU1Qg UGhpbGlwcGUgQ29ybnUgd3JvdGU6Cj4gPiAKPiA+PiBBZGQgdGhlIDMgb3B0aW9uYWwgcG93ZXIg c3VwcGxpZXMgdXNpbmcgdGhlIGV4YWN0IGRlc2NyaXB0aW9uCj4gPj4gZm91bmQgaW4gdGhlIGRv Y3VtZW50IG5hbWVkCj4gPj4gIlNpSTkwMjJBL1NpSTkwMjRBIEhETUkgVHJhbnNtaXR0ZXIgRGF0 YSBTaGVldCAoQXVndXN0IDIwMTYpIi4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IFBoaWxpcHBl IENvcm51IDxwaGlsaXBwZS5jb3JudUBzdC5jb20+Cj4gPj4gLS0tCj4gPj4gCj4gPj4gICBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2Uvc2lpOTAyeC50eHQg fCAzICsrKwo+ID4+ICAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+ID4+Cj4gPj4g ZGlmZiAtLWdpdAo+ID4+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs YXkvYnJpZGdlL3NpaTkwMngudHh0Cj4gPj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9icmlkZ2Uvc2lpOTAyeC50eHQgaW5kZXgKPiA+PiA1NmEzZTY4Y2NiODAu LmNmNTM2NzhmZTU3NCAxMDA2NDQKPiA+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvZGlzcGxheS9icmlkZ2Uvc2lpOTAyeC50eHQKPiA+PiArKysgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2Uvc2lpOTAyeC50eHQKPiA+PiBA QCAtOCw2ICs4LDkgQEAgT3B0aW9uYWwgcHJvcGVydGllczoKPiA+PiAgIAktIGludGVycnVwdHMt ZXh0ZW5kZWQgb3IgaW50ZXJydXB0LXBhcmVudCArIGludGVycnVwdHM6IGRlc2NyaWJlCj4gPj4g ICAJICB0aGUgaW50ZXJydXB0IGxpbmUgdXNlZCB0byBpbmZvcm0gdGhlIGhvc3QgYWJvdXQgaG90 cGx1ZyBldmVudHMuCj4gPj4gICAJLSByZXNldC1ncGlvczogT0YgZGV2aWNlLXRyZWUgZ3BpbyBz cGVjaWZpY2F0aW9uIGZvciBSU1RfTiBwaW4uCj4gPj4gKwktIGlvdmNjLXN1cHBseTogSS9PIHN1 cHBseSB2b2x0YWdlICgxLjhWIG9yIDMuM1YsIGhvc3QtZGVwZW5kZW50KS4KPiA+PiArCS0gYXZj YzEyLXN1cHBseTogVE1EUyBhbmFsb2cgc3VwcGx5IHZvbHRhZ2UgKDEuMlYpLgo+ID4+ICsJLSBj dmNjMTItc3VwcGx5OiBEaWdpdGFsIGNvcmUgc3VwcGx5IHZvbHRhZ2UgKDEuMlYpLgo+ID4gCj4g PiBJdCBzZWVtcyB0aGF0IHRoZSBBVkNDMTIgYW5kIENWQ0MxMiBwb3dlciBzdXBwbGllcyBhcmUg dXN1YWxseSBkZXJpdmVkCj4gPiBmcm9tIHRoZSBzYW1lIHNvdXJjZS4gSG93IGFib3V0IHN0YXJ0 aW5nIHdpdGggb25lIERUIHByb3BlcnR5IGZvciBib3RoLAo+ID4gYW5kIGFkZGluZyBhIHNlY29u ZCBvbmUgbGF0ZXIgaWYgbmVlZGVkID8KPiAKPiBXZWxsLCBJIGRvIG5vdCBrbm93IHdoYXQgaXMg dGhlIGJlc3QuIEhlcmUgSSB0b29rIHRoZSBkZXNjcmlwdGlvbiBmcm9tIAo+IHRoZSBkb2N1bWVu dGF0aW9uLCBhbmQgdG8gYWxsb3cgYWxsIHBvc3NpYmxlIGJvYXJkIGNvbmZpZ3VyYXRpb25zLCBJ IAo+IGFkZGVkIHRoZXNlIHN1cHBsaWVzIGFzICJvcHRpb25hbCIgcHJvcGVydGllczogaWYgdGhl cmUgaXMgb25seSBvbmUgMXYyIAo+IHJlZ3VsYXRvciBvbiB0aGUgYm9hcmQsIHRoZSBkdCB3aWxs IGNvbnRhaW4gb25seSBhdmNjMTIgb3IgY3ZjYzEyIGFuZCAKPiBldmVyeXRoaW5nIHdpbGwgd29y ayBmaW5lICh3ZSB3aWxsIGhhdmUgYSBkdW1teSByZWd1bGF0b3IgZm9yIHRoZSAKPiBtaXNzaW5n IG9wdGlvbmFsIDF2MiByZWcpLCBpZiBib3RoIHJlZ3VsYXRvcnMgYXJlIHRoZXJlIGZvciBhbnkg cmVhc29ucyAKPiAoc3RhYmlsaXR5LCBub2lzZSwgd2hhdGV2ZXIuLi4pIHRoZW4gYm90aCBlbnRy aWVzIHdpbGwgYmUgaW4gdGhlIGR0Lgo+IAo+IElmIHlvdSBjb25maXJtIHlvdSBwcmVmZXIgYSBz aW5nbGUgMXYyIHN1cHBseSAobmFtZWQgZm9yIGluc3RhbmNlIAo+ICJ2Y2MxMi1zdXBwbHkiKSB0 aGVuIEkgd2lsbCBkbyA6LSkKClBsZWFzZSBzZWUgaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTgtQXByaWwvCjE3MjQwMC5odG1sIChhbmQgdGhlIG1l c3NhZ2VzIHRoYXQgbGVhZCB0byBpdCkgYW5kIGh0dHBzOi8vCmxpc3RzLmZyZWVkZXNrdG9wLm9y Zy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAxOC1NYXJjaC8xNzA3NjMuaHRtbC4KCj4gPj4gICBPcHRp b25hbCBzdWJub2RlczoKPiA+PiAgIAktIHZpZGVvIGlucHV0OiB0aGlzIHN1Ym5vZGUgY2FuIGNv bnRhaW4gYSB2aWRlbyBpbnB1dCBwb3J0IG5vZGUKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5j aGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751903AbeDSLJq (ORCPT ); Thu, 19 Apr 2018 07:09:46 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:35008 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbeDSLJp (ORCPT ); Thu, 19 Apr 2018 07:09:45 -0400 From: Laurent Pinchart To: Philippe CORNU Cc: Archit Taneja , Andrzej Hajda , David Airlie , Rob Herring , Mark Rutland , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yannick FERTRE , Benjamin Gaignard , Alexandre TORGUE Subject: Re: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Thu, 19 Apr 2018 14:09:52 +0300 Message-ID: <1733412.i2Wslp7VkI@avalon> Organization: Ideas on Board Oy In-Reply-To: References: <20180410051927.8268-1-philippe.cornu@st.com> <20599695.GSkeUvMnvx@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philippe, On Thursday, 19 April 2018 12:31:15 EEST Philippe CORNU wrote: > On 04/19/2018 10:11 AM, Laurent Pinchart wrote: > > On Tuesday, 10 April 2018 08:19:26 EEST Philippe Cornu wrote: > > > >> Add the 3 optional power supplies using the exact description > >> found in the document named > >> "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". > >> > >> Signed-off-by: Philippe Cornu > >> --- > >> > >> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> b/Documentation/devicetree/bindings/display/bridge/sii902x.txt index > >> 56a3e68ccb80..cf53678fe574 100644 > >> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> @@ -8,6 +8,9 @@ Optional properties: > >> - interrupts-extended or interrupt-parent + interrupts: describe > >> the interrupt line used to inform the host about hotplug events. > >> - reset-gpios: OF device-tree gpio specification for RST_N pin. > >> + - iovcc-supply: I/O supply voltage (1.8V or 3.3V, host-dependent). > >> + - avcc12-supply: TMDS analog supply voltage (1.2V). > >> + - cvcc12-supply: Digital core supply voltage (1.2V). > > > > It seems that the AVCC12 and CVCC12 power supplies are usually derived > > from the same source. How about starting with one DT property for both, > > and adding a second one later if needed ? > > Well, I do not know what is the best. Here I took the description from > the documentation, and to allow all possible board configurations, I > added these supplies as "optional" properties: if there is only one 1v2 > regulator on the board, the dt will contain only avcc12 or cvcc12 and > everything will work fine (we will have a dummy regulator for the > missing optional 1v2 reg), if both regulators are there for any reasons > (stability, noise, whatever...) then both entries will be in the dt. > > If you confirm you prefer a single 1v2 supply (named for instance > "vcc12-supply") then I will do :-) Please see https://lists.freedesktop.org/archives/dri-devel/2018-April/ 172400.html (and the messages that lead to it) and https:// lists.freedesktop.org/archives/dri-devel/2018-March/170763.html. > >> Optional subnodes: > >> - video input: this subnode can contain a video input port node -- Regards, Laurent Pinchart