From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:53338 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726836AbeJPGJ1 (ORCPT ); Tue, 16 Oct 2018 02:09:27 -0400 From: Laurent Pinchart To: Fabrizio Castro Cc: David Airlie , Rob Herring , Geert Uytterhoeven , Mark Rutland , Simon Horman , Magnus Damm , Russell King , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Paterson , Biju Das Subject: Re: [PATCH 3/5] drm: rcar-du: Add r8a77470 support Date: Tue, 16 Oct 2018 01:22:21 +0300 Message-ID: <1733512.u0bX59egiB@avalon> In-Reply-To: <1537553311-8831-4-git-send-email-fabrizio.castro@bp.renesas.com> References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <1537553311-8831-4-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Fabrizio, Thank you for the patch. On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote: > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..c07d3f1 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -77,6 +77,31 @@ static const struct rcar_du_device_info > rzg1_du_r8a7745_info = { }, > }; > > +static const struct rcar_du_device_info rzg1_du_r8a77470_info = { > + .gen = 2, > + .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > + | RCAR_DU_FEATURE_EXT_CTRL_REGS, The DU driver has recently gained two new feature flags, RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC. I believe that both should be set here. Could you please confirm (and test) ? > + .channels_mask = BIT(1) | BIT(0), > + .routes = { > + /* > + * R8A77470 has two RGB outputs, one LVDS output, and > + * one analog video output (unsupported) I'd write this "and one (currently unsupported) analog video output" to match the other device entries. With this fixed, Reviewed-by: Laurent Pinchart > + */ > + [RCAR_DU_OUTPUT_DPAD0] = { > + .possible_crtcs = BIT(0), > + .port = 0, > + }, > + [RCAR_DU_OUTPUT_DPAD1] = { > + .possible_crtcs = BIT(1), > + .port = 1, > + }, > + [RCAR_DU_OUTPUT_LVDS0] = { > + .possible_crtcs = BIT(0) | BIT(1), > + .port = 2, > + }, > + }, > +}; > + > static const struct rcar_du_device_info rcar_du_r8a7779_info = { > .gen = 2, > .features = 0, > @@ -297,6 +322,7 @@ static const struct rcar_du_device_info > rcar_du_r8a77970_info = { static const struct of_device_id > rcar_du_of_table[] = { > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > + { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info }, > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info }, > { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info }, -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Tue, 16 Oct 2018 01:22:21 +0300 Subject: [PATCH 3/5] drm: rcar-du: Add r8a77470 support In-Reply-To: <1537553311-8831-4-git-send-email-fabrizio.castro@bp.renesas.com> References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <1537553311-8831-4-git-send-email-fabrizio.castro@bp.renesas.com> Message-ID: <1733512.u0bX59egiB@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Fabrizio, Thank you for the patch. On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote: > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..c07d3f1 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -77,6 +77,31 @@ static const struct rcar_du_device_info > rzg1_du_r8a7745_info = { }, > }; > > +static const struct rcar_du_device_info rzg1_du_r8a77470_info = { > + .gen = 2, > + .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > + | RCAR_DU_FEATURE_EXT_CTRL_REGS, The DU driver has recently gained two new feature flags, RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC. I believe that both should be set here. Could you please confirm (and test) ? > + .channels_mask = BIT(1) | BIT(0), > + .routes = { > + /* > + * R8A77470 has two RGB outputs, one LVDS output, and > + * one analog video output (unsupported) I'd write this "and one (currently unsupported) analog video output" to match the other device entries. With this fixed, Reviewed-by: Laurent Pinchart > + */ > + [RCAR_DU_OUTPUT_DPAD0] = { > + .possible_crtcs = BIT(0), > + .port = 0, > + }, > + [RCAR_DU_OUTPUT_DPAD1] = { > + .possible_crtcs = BIT(1), > + .port = 1, > + }, > + [RCAR_DU_OUTPUT_LVDS0] = { > + .possible_crtcs = BIT(0) | BIT(1), > + .port = 2, > + }, > + }, > +}; > + > static const struct rcar_du_device_info rcar_du_r8a7779_info = { > .gen = 2, > .features = 0, > @@ -297,6 +322,7 @@ static const struct rcar_du_device_info > rcar_du_r8a77970_info = { static const struct of_device_id > rcar_du_of_table[] = { > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > + { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info }, > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info }, > { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info }, -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 3/5] drm: rcar-du: Add r8a77470 support Date: Tue, 16 Oct 2018 01:22:21 +0300 Message-ID: <1733512.u0bX59egiB@avalon> References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <1537553311-8831-4-git-send-email-fabrizio.castro@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1537553311-8831-4-git-send-email-fabrizio.castro@bp.renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Mark Rutland , Simon Horman , Chris Paterson , Geert Uytterhoeven , devicetree@vger.kernel.org, David Airlie , Magnus Damm , Russell King , dri-devel@lists.freedesktop.org, Biju Das , linux-renesas-soc@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgRmFicml6aW8sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIEZyaWRheSwgMjEgU2Vw dGVtYmVyIDIwMTggMjE6MDg6MjkgRUVTVCBGYWJyaXppbyBDYXN0cm8gd3JvdGU6Cj4gQWRkIFJa L0cxQyAoYS5rLmEuIHI4YTc3NDcwKSBzdXBwb3J0IHRvIHRoZSBSLUNhciBEVSBkcml2ZXIuCj4g Cj4gU2lnbmVkLW9mZi1ieTogRmFicml6aW8gQ2FzdHJvIDxmYWJyaXppby5jYXN0cm9AYnAucmVu ZXNhcy5jb20+Cj4gUmV2aWV3ZWQtYnk6IEJpanUgRGFzIDxiaWp1LmRhc0BicC5yZW5lc2FzLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyB8IDI2ICsr KysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25z KCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2 LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgaW5kZXggMDJhZWU2 Yy4uYzA3ZDNmMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+IEBA IC03Nyw2ICs3NywzMSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8K PiByemcxX2R1X3I4YTc3NDVfaW5mbyA9IHsgfSwKPiAgfTsKPiAKPiArc3RhdGljIGNvbnN0IHN0 cnVjdCByY2FyX2R1X2RldmljZV9pbmZvIHJ6ZzFfZHVfcjhhNzc0NzBfaW5mbyA9IHsKPiArCS5n ZW4gPSAyLAo+ICsJLmZlYXR1cmVzID0gUkNBUl9EVV9GRUFUVVJFX0NSVENfSVJRX0NMT0NLCj4g KwkJICB8IFJDQVJfRFVfRkVBVFVSRV9FWFRfQ1RSTF9SRUdTLAoKVGhlIERVIGRyaXZlciBoYXMg cmVjZW50bHkgZ2FpbmVkIHR3byBuZXcgZmVhdHVyZSBmbGFncywgClJDQVJfRFVfRkVBVFVSRV9J TlRFUkxBQ0VEIGFuZCBSQ0FSX0RVX0ZFQVRVUkVfVFZNX1NZTkMuIEkgYmVsaWV2ZSB0aGF0IGJv dGggCnNob3VsZCBiZSBzZXQgaGVyZS4gQ291bGQgeW91IHBsZWFzZSBjb25maXJtIChhbmQgdGVz dCkgPwoKPiArCS5jaGFubmVsc19tYXNrID0gQklUKDEpIHwgQklUKDApLAo+ICsJLnJvdXRlcyA9 IHsKPiArCQkvKgo+ICsJCSAqIFI4QTc3NDcwIGhhcyB0d28gUkdCIG91dHB1dHMsIG9uZSBMVkRT IG91dHB1dCwgYW5kCj4gKwkJICogb25lIGFuYWxvZyB2aWRlbyBvdXRwdXQgKHVuc3VwcG9ydGVk KQoKSSdkIHdyaXRlIHRoaXMgImFuZCBvbmUgKGN1cnJlbnRseSB1bnN1cHBvcnRlZCkgYW5hbG9n IHZpZGVvIG91dHB1dCIgdG8gbWF0Y2ggCnRoZSBvdGhlciBkZXZpY2UgZW50cmllcy4gV2l0aCB0 aGlzIGZpeGVkLAoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hh cnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gKwkJICovCj4gKwkJW1JDQVJfRFVfT1VUUFVUX0RQQUQw XSA9IHsKPiArCQkJLnBvc3NpYmxlX2NydGNzID0gQklUKDApLAo+ICsJCQkucG9ydCA9IDAsCj4g KwkJfSwKPiArCQlbUkNBUl9EVV9PVVRQVVRfRFBBRDFdID0gewo+ICsJCQkucG9zc2libGVfY3J0 Y3MgPSBCSVQoMSksCj4gKwkJCS5wb3J0ID0gMSwKPiArCQl9LAo+ICsJCVtSQ0FSX0RVX09VVFBV VF9MVkRTMF0gPSB7Cj4gKwkJCS5wb3NzaWJsZV9jcnRjcyA9IEJJVCgwKSB8IEJJVCgxKSwKPiAr CQkJLnBvcnQgPSAyLAo+ICsJCX0sCj4gKwl9LAo+ICt9Owo+ICsKPiAgc3RhdGljIGNvbnN0IHN0 cnVjdCByY2FyX2R1X2RldmljZV9pbmZvIHJjYXJfZHVfcjhhNzc3OV9pbmZvID0gewo+ICAJLmdl biA9IDIsCj4gIAkuZmVhdHVyZXMgPSAwLAo+IEBAIC0yOTcsNiArMzIyLDcgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCByY2FyX2R1X2RldmljZV9pbmZvCj4gcmNhcl9kdV9yOGE3Nzk3MF9pbmZvID0g eyBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZAo+IHJjYXJfZHVfb2ZfdGFibGVbXSA9 IHsKPiAgCXsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxkdS1yOGE3NzQzIiwgLmRhdGEgPSAmcnpn MV9kdV9yOGE3NzQzX2luZm8gfSwKPiAgCXsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxkdS1yOGE3 NzQ1IiwgLmRhdGEgPSAmcnpnMV9kdV9yOGE3NzQ1X2luZm8gfSwKPiArCXsgLmNvbXBhdGlibGUg PSAicmVuZXNhcyxkdS1yOGE3NzQ3MCIsIC5kYXRhID0gJnJ6ZzFfZHVfcjhhNzc0NzBfaW5mbyB9 LAo+ICAJeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3NzkiLCAuZGF0YSA9ICZyY2Fy X2R1X3I4YTc3NzlfaW5mbyB9LAo+ICAJeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3 OTAiLCAuZGF0YSA9ICZyY2FyX2R1X3I4YTc3OTBfaW5mbyB9LAo+ICAJeyAuY29tcGF0aWJsZSA9 ICJyZW5lc2FzLGR1LXI4YTc3OTEiLCAuZGF0YSA9ICZyY2FyX2R1X3I4YTc3OTFfaW5mbyB9LAoK LS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=