From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
Jan Viktorin <viktorin@rehivetech.com>
Cc: dev@dpdk.org, jianbo.liu@linaro.org
Subject: Re: [PATCH v5] examples/l3fwd: em path performance fix
Date: Fri, 18 Mar 2016 12:00:24 +0100 [thread overview]
Message-ID: <1734050.PspUeD4iGQ@xps13> (raw)
In-Reply-To: <20160318105158.GA13693@localhost.localdomain>
2016-03-18 16:22, Jerin Jacob:
> On Fri, Mar 18, 2016 at 11:04:49AM +0100, Thomas Monjalon wrote:
> > 2016-03-18 10:52, Tomasz Kulasek:
> > > +#if !defined(NO_HASH_MULTI_LOOKUP) && defined(__ARM_NEON)
> >
> > I think we should use CONFIG_RTE_ARCH_ARM_NEON here.
> > Any ARM maintainer to confirm?
>
> __ARM_NEON should work existing GCC, but it is better to use
> RTE_MACHINE_CPUFLAG_NEON as
> -it has been generated by probing the compiler capabilities.
> -it's future-proof solution to support clang or other gcc versions in
> future
I agree to use RTE_MACHINE_CPUFLAG_NEON.
I just don't understand why CONFIG_RTE_ARCH_ARM_NEON has been introduced.
It seems to be used to disable NEON on ARMv7:
ifeq ($(CONFIG_RTE_ARCH_ARM_NEON),y)
MACHINE_CFLAGS += -mfpu=neon
endif
next prev parent reply other threads:[~2016-03-18 11:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 17:23 [PATCH] examples/l3fwd: em path performance fix Tomasz Kulasek
2016-03-07 6:19 ` Xu, Qian Q
2016-03-08 12:58 ` [PATCH v2] " Tomasz Kulasek
2016-03-11 11:14 ` Thomas Monjalon
2016-03-11 12:28 ` Kulasek, TomaszX
2016-03-11 12:10 ` [PATCH v3] " Tomasz Kulasek
2016-03-11 16:23 ` Thomas Monjalon
2016-03-11 17:48 ` Kulasek, TomaszX
2016-03-15 14:31 ` Kulasek, TomaszX
2016-03-15 14:49 ` Thomas Monjalon
2016-03-15 16:06 ` Kulasek, TomaszX
2016-03-15 19:42 ` Odp.: " Czekaj, Maciej
2016-03-18 9:36 ` [PATCH v4] " Tomasz Kulasek
2016-03-18 9:43 ` Kulasek, TomaszX
2016-03-18 9:52 ` [PATCH v5] " Tomasz Kulasek
2016-03-18 10:04 ` Thomas Monjalon
2016-03-18 10:52 ` Jerin Jacob
2016-03-18 11:00 ` Thomas Monjalon [this message]
2016-03-18 11:16 ` [PATCH] examples/l3fwd: prefer probed NEON flag to ARM gcc flag Thomas Monjalon
2016-03-18 11:20 ` [PATCH v2] " Thomas Monjalon
2016-03-18 11:56 ` [PATCH v5] examples/l3fwd: em path performance fix Jan Viktorin
2016-03-18 12:45 ` Kulasek, TomaszX
2016-03-18 12:50 ` Jan Viktorin
2016-03-18 13:31 ` [PATCH v6] " Tomasz Kulasek
2016-03-21 11:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1734050.PspUeD4iGQ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=tomaszx.kulasek@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.