All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Muezerie <andremue@linux.microsoft.com>
To: andremue@linux.microsoft.com
Cc: bruce.richardson@intel.com, dev@dpdk.org, vladimir.medvedkin@intel.com
Subject: [PATCH v2] app/test: fix stack overflow in lpm6_perf_autotest
Date: Fri, 13 Dec 2024 09:08:22 -0800	[thread overview]
Message-ID: <1734109702-3647-1-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1734057571-20367-1-git-send-email-andremue@linux.microsoft.com>

Test lpm6_perf_autotest was hitting a stack overflow on Windows
with both MSVC and Clang.

The fix is to move some of the data from the stack to the heap.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 app/test/test_lpm6_perf.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/app/test/test_lpm6_perf.c b/app/test/test_lpm6_perf.c
index 1860a99ed6..a09e8611ce 100644
--- a/app/test/test_lpm6_perf.c
+++ b/app/test/test_lpm6_perf.c
@@ -10,6 +10,7 @@
 
 #include <rte_cycles.h>
 #include <rte_random.h>
+#include <rte_malloc.h>
 #include <rte_memory.h>
 #include <rte_lpm6.h>
 
@@ -117,8 +118,14 @@ test_lpm6_perf(void)
 	total_time = 0;
 	count = 0;
 
-	struct rte_ipv6_addr ip_batch[NUM_IPS_ENTRIES];
-	int32_t next_hops[NUM_IPS_ENTRIES];
+	struct rte_ipv6_addr *ip_batch =
+			(struct rte_ipv6_addr *)rte_malloc("ip_batch",
+			sizeof(struct rte_ipv6_addr) * NUM_IPS_ENTRIES, 0);
+	TEST_LPM_ASSERT(ip_batch != NULL);
+
+	int32_t *next_hops = (int32_t *)rte_malloc("next_hops",
+			sizeof(int32_t) * NUM_IPS_ENTRIES, 0);
+	TEST_LPM_ASSERT(next_hops != NULL);
 
 	for (i = 0; i < NUM_IPS_ENTRIES; i++)
 		ip_batch[i] = large_ips_table[i].ip;
@@ -153,6 +160,9 @@ test_lpm6_perf(void)
 	printf("Average LPM Delete: %g cycles\n",
 			(double)total_time / NUM_ROUTE_ENTRIES);
 
+	rte_free(next_hops);
+	rte_free(ip_batch);
+
 	rte_lpm6_delete_all(lpm);
 	rte_lpm6_free(lpm);
 
-- 
2.47.0.vfs.0.3


  parent reply	other threads:[~2024-12-13 17:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  2:39 [PATCH] app/test: fix stack overflow in lpm6_perf_autotest Andre Muezerie
2024-12-13 10:22 ` Medvedkin, Vladimir
2024-12-13 17:05   ` Andre Muezerie
2024-12-13 17:08   ` Stephen Hemminger
2024-12-13 17:08 ` Andre Muezerie [this message]
2024-12-13 17:15   ` [PATCH v2] " Stephen Hemminger
2024-12-18 15:12     ` Andre Muezerie
2024-12-18 15:21 ` [PATCH v3] " Andre Muezerie
2025-03-05 10:08   ` Bruce Richardson
2025-03-05 14:45     ` Andre Muezerie
2025-03-05 20:04       ` Medvedkin, Vladimir
2025-03-19  2:52         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1734109702-3647-1-git-send-email-andremue@linux.microsoft.com \
    --to=andremue@linux.microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.