From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] net/mlx5: fix handling of small mbuf sizes
Date: Mon, 07 Nov 2016 18:22:59 +0100
Message-ID: <1734224.1G63DZ4fph@xps13>
References: <937aac679e571c4fff8ab720f4dd910fe10a283e.1477296585.git.rasland@mellanox.com>
 <20161028121906.GW5733@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 2B5371DB1
 for <dev@dpdk.org>; Mon,  7 Nov 2016 18:23:01 +0100 (CET)
Received: by mail-wm0-f43.google.com with SMTP id p190so196937623wmp.1
 for <dev@dpdk.org>; Mon, 07 Nov 2016 09:23:01 -0800 (PST)
In-Reply-To: <20161028121906.GW5733@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-10-28 14:19, Adrien Mazarguil:
> On Mon, Oct 24, 2016 at 11:10:59AM +0300, Raslan Darawsheh wrote:
> > When mbufs are smaller than MRU, multi-segment support must be enabled to
> > default set when not in promiscuous or allmulticast modes.
> > 
> > Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support")
> > 
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
[...]
> > +	/* If smaller than MRU, multi-segment support must be enabled. */
> > +	if (mb_len < (priv->mtu > dev->data->dev_conf.rxmode.max_rx_pkt_len ?
> > +		     dev->data->dev_conf.rxmode.max_rx_pkt_len :
> > +		     priv->mtu
> > +		     ))
> 
> Let's move poor "))" to the end of the previous line.
[...]
> Besides the above comment:
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Fixed and applied, thanks