From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Wed, 12 Jul 2017 12:54:11 +0000 Subject: Re: [PATCH] fbdev: Nuke FBINFO_MODULE Message-Id: <1734271.ijK3T0ECI9@amdc3058> List-Id: References: <20170706125735.28299-3-daniel.vetter@ffwll.ch> <1903695.PIoOfWhuj9@amdc3058> <20170712124214.t2i2ldlrwc5gf5aw@phenom.ffwll.local> In-Reply-To: <20170712124214.t2i2ldlrwc5gf5aw@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , linux-fbdev@vger.kernel.org, DRI Development , Daniel Vetter On Wednesday, July 12, 2017 02:42:14 PM Daniel Vetter wrote: > On Wed, Jul 12, 2017 at 12:41:34PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Tuesday, July 11, 2017 04:52:19 PM Daniel Vetter wrote: > > > Instead check info->ops->owner, which amounts to the same. > > > > > > Spotted because I want to remove the pile of broken and cargo-culted > > > fb_info->flags assignments in drm drivers. > > > > > > v2: Fixup matrox (reported by kbuild). Also nuke FBINFO_FLAG_* defines > > > that I've failed to spot. > > > > > > v3: Don't nuke FBINFO_FLAG_DEFAULT, that's used all over the place. > > > > > > Cc: Bartlomiej Zolnierkiewicz > > > Cc: linux-fbdev@vger.kernel.org > > > Signed-off-by: Daniel Vetter > > > > Acked-by: Bartlomiej Zolnierkiewicz > > Do you plan to pick these two patches up yourself, or do you expect me to > merge them? Since the original patchset contained DRM changes (two last patches) depending on fbdev changes (two first patches, the patch being discussed was the second one) I assumed that you would like to take them all through DRM tree. If this is not what is preferred, please tell me. > I'm always confused when the official maintainer acks something without > saying anything else ... Point taken, I will try to be more verbose next time. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] fbdev: Nuke FBINFO_MODULE Date: Wed, 12 Jul 2017 14:54:11 +0200 Message-ID: <1734271.ijK3T0ECI9@amdc3058> References: <20170706125735.28299-3-daniel.vetter@ffwll.ch> <1903695.PIoOfWhuj9@amdc3058> <20170712124214.t2i2ldlrwc5gf5aw@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <20170712124214.t2i2ldlrwc5gf5aw@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , linux-fbdev@vger.kernel.org, DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkbmVzZGF5LCBKdWx5IDEyLCAyMDE3IDAyOjQyOjE0IFBNIERhbmllbCBWZXR0ZXIgd3Jv dGU6Cj4gT24gV2VkLCBKdWwgMTIsIDIwMTcgYXQgMTI6NDE6MzRQTSArMDIwMCwgQmFydGxvbWll aiBab2xuaWVya2lld2ljeiB3cm90ZToKPiA+IE9uIFR1ZXNkYXksIEp1bHkgMTEsIDIwMTcgMDQ6 NTI6MTkgUE0gRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ID4gSW5zdGVhZCBjaGVjayBpbmZvLT5v cHMtPm93bmVyLCB3aGljaCBhbW91bnRzIHRvIHRoZSBzYW1lLgo+ID4gPiAKPiA+ID4gU3BvdHRl ZCBiZWNhdXNlIEkgd2FudCB0byByZW1vdmUgdGhlIHBpbGUgb2YgYnJva2VuIGFuZCBjYXJnby1j dWx0ZWQKPiA+ID4gZmJfaW5mby0+ZmxhZ3MgYXNzaWdubWVudHMgaW4gZHJtIGRyaXZlcnMuCj4g PiA+IAo+ID4gPiB2MjogRml4dXAgbWF0cm94IChyZXBvcnRlZCBieSBrYnVpbGQpLiBBbHNvIG51 a2UgRkJJTkZPX0ZMQUdfKiBkZWZpbmVzCj4gPiA+IHRoYXQgSSd2ZSBmYWlsZWQgdG8gc3BvdC4K PiA+ID4gCj4gPiA+IHYzOiBEb24ndCBudWtlIEZCSU5GT19GTEFHX0RFRkFVTFQsIHRoYXQncyB1 c2VkIGFsbCBvdmVyIHRoZSBwbGFjZS4KPiA+ID4gCj4gPiA+IENjOiBCYXJ0bG9taWVqIFpvbG5p ZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+Cj4gPiA+IENjOiBsaW51eC1mYmRl dkB2Z2VyLmtlcm5lbC5vcmcKPiA+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBpbnRlbC5jb20+Cj4gPiAKPiA+IEFja2VkLWJ5OiBCYXJ0bG9taWVqIFpvbG5p ZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+Cj4gCj4gRG8geW91IHBsYW4gdG8g cGljayB0aGVzZSB0d28gcGF0Y2hlcyB1cCB5b3Vyc2VsZiwgb3IgZG8geW91IGV4cGVjdCBtZSB0 bwo+IG1lcmdlIHRoZW0/CgpTaW5jZSB0aGUgb3JpZ2luYWwgcGF0Y2hzZXQgY29udGFpbmVkIERS TSBjaGFuZ2VzICh0d28gbGFzdCBwYXRjaGVzKQpkZXBlbmRpbmcgb24gZmJkZXYgY2hhbmdlcyAo dHdvIGZpcnN0IHBhdGNoZXMsIHRoZSBwYXRjaCBiZWluZyBkaXNjdXNzZWQKd2FzIHRoZSBzZWNv bmQgb25lKSBJIGFzc3VtZWQgdGhhdCB5b3Ugd291bGQgbGlrZSB0byB0YWtlIHRoZW0gYWxsCnRo cm91Z2ggRFJNIHRyZWUuIElmIHRoaXMgaXMgbm90IHdoYXQgaXMgcHJlZmVycmVkLCBwbGVhc2Ug dGVsbCBtZS4KCj4gSSdtIGFsd2F5cyBjb25mdXNlZCB3aGVuIHRoZSBvZmZpY2lhbCBtYWludGFp bmVyIGFja3Mgc29tZXRoaW5nIHdpdGhvdXQKPiBzYXlpbmcgYW55dGhpbmcgZWxzZSAuLi4KClBv aW50IHRha2VuLCBJIHdpbGwgdHJ5IHRvIGJlIG1vcmUgdmVyYm9zZSBuZXh0IHRpbWUuCgpCZXN0 IHJlZ2FyZHMsCi0tCkJhcnRsb21pZWogWm9sbmllcmtpZXdpY3oKU2Ftc3VuZyBSJkQgSW5zdGl0 dXRlIFBvbGFuZApTYW1zdW5nIEVsZWN0cm9uaWNzCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK