From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Matthew Hall <mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: IPv6 Offload Capabilities
Date: Wed, 14 Jan 2015 12:29:55 +0100 [thread overview]
Message-ID: <1735915.0Agkfn8QEd@xps13> (raw)
In-Reply-To: <20150106052537.GB17455-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
Hi Matthew,
2015-01-05 21:25, Matthew Hall:
> > > 2) The checksum operations are kind of a hodgepodge and don't always have a
> > > consistent vision to them... some things like the 16-bit-based IP checksum
> > > appear to be missing any routine, including any accelerated one when the
> > > offload doesn't work (like for ICMPv4, ICMPv6, and any IPv6 datagrams, or
> > > other weird crap like IPv6 pseudo headers, even contemplating those gives me
> > > a headache, but at least my greenfield code for it works now).
> >
> > Please detail which function is missing for which usage.
>
> rte_hash_crc exists, rte_hash_crc_4byte exists, there is no rte_hash_ip_cksum
> to use when checksum offloading doesn't work for some reason (in BSD it's
> called in_cksum). The jhash and CRC API's don't look to be consistent /
> compatible. An expandable API with some enum of hash algorithms and a standard
> calling convention for accelerated / special algorithms (like ones which
> assume 4-byte input) would make this more generic.
[...]
> But the larger architectural point was my proposed goal that all of the
> various kinds of hashes (flow hashes, checksums / packet hashes, table lookup
> hashes, etc.) could use a consistent pluggable API so we could easily move
> back and forth between them and write clean consistent code any time a hash is
> being used.
Thank you for your detailed comments.
Are you saying that you want to work on such hash API for DPDK?
--
Thomas
next prev parent reply other threads:[~2015-01-14 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 7:56 IPv6 Offload Capabilities Gal Sagie
[not found] ` <CAG9LJa6qY=LeiN+sPQGx7ok-RWwf9uXm_Vz4-2NLTW8XvGoU5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-05 8:09 ` Matthew Hall
[not found] ` <C6595EEB-8329-49F9-9745-52887AE9F848-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2015-01-05 8:36 ` Thomas Monjalon
2015-01-06 5:25 ` Matthew Hall
[not found] ` <20150106052537.GB17455-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2015-01-06 5:30 ` Matthew Hall
2015-01-14 11:29 ` Thomas Monjalon [this message]
2015-01-05 8:33 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1735915.0Agkfn8QEd@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.