From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFDEC433E0 for ; Mon, 15 Mar 2021 16:53:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3331864F33 for ; Mon, 15 Mar 2021 16:53:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3331864F33 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n/rpebOf1L4Wh6dLMYCnYJt3I5ZajbqoqZ5RlWhN1sg=; b=NmdyCV6Xr0rb/V53MH8q888EE y5Iu3VhwoHf8A0SyHJ38faZ+kOEXLgmVkp2+NHXgwIniR0hp9O/DdRMyPavBXJcDOPr1dbkrvT/z+ 0JaCu85QMkgXuzUrrHxhlimPbsuOuwAqWXLfGZpqj/UxogOtJvZ009Ye4ZUbvYa05mCw8CsECZaXC Z4zmsUCpb1akHCasaoG+1t9Tu6zcjQY4MItAN4++iq6w6sXw8v12lUJZAChitMMBVXKvnx8aF/pEG /+eqeQb8dpHLnx+L44QOxfuMUIrTHhy4rAYTMj4qKS+QXZ5LwXGnLFhI3SErx923iXxDugm64/69G ECJbKZ5Xg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLqSz-00GOvS-Jb; Mon, 15 Mar 2021 16:53:17 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLqSl-00GOtt-HQ; Mon, 15 Mar 2021 16:53:08 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLqSI-0001JB-1E; Mon, 15 Mar 2021 17:52:34 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Robin Murphy , Geert Uytterhoeven Cc: CN_SZTL , Rob Herring , Jagan Teki , Chen-Yu Tsai , Geert Uytterhoeven , David Bauer , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Johan Jonker , Michael Trimarchi , Marty Jones , Jensen Huang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , kernel test robot Subject: Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S Date: Mon, 15 Mar 2021 17:52:32 +0100 Message-ID: <17376355.sWSEgdgrri@diego> In-Reply-To: References: <20210313032515.12590-1-cnsztl@gmail.com> <67b314e7-92b9-8025-1a41-9b7da6ff2249@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_165306_488265_C03F0B34 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gTW9udGFnLCAxNS4gTcOkcnogMjAyMSwgMTc6Mzg6MzcgQ0VUIHNjaHJpZWIgR2VlcnQgVXl0 dGVyaG9ldmVuOgo+IEhpIFJvYmluLAo+IAo+IE9uIE1vbiwgTWFyIDE1LCAyMDIxIGF0IDU6MzIg UE0gUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4gd3JvdGU6Cj4gPiBPbiAyMDIx LTAzLTEzIDEzOjIyLCBDTl9TWlRMIHdyb3RlOgo+ID4gPiBSb2JpbiBNdXJwaHkgPHJvYmluLm11 cnBoeUBhcm0uY29tPiDkuo4yMDIx5bm0M+aciDEz5pel5ZGo5YWtIOS4i+WNiDc6NTXlhpnpgZPv vJoKPiA+ID4+Cj4gPiA+PiBPbiAyMDIxLTAzLTEzIDAzOjI1LCBUaWFubGluZyBTaGVuIHdyb3Rl Ogo+ID4gPj4+ICsgICAgIGdwaW8tbGVkcyB7Cj4gPiA+Pj4gKyAgICAgICAgICAgICBjb21wYXRp YmxlID0gImdwaW8tbGVkcyI7Cj4gPiA+Pj4gKyAgICAgICAgICAgICBwaW5jdHJsLTAgPSA8Jmxh bl9sZWRfcGluPiwgPCZzeXNfbGVkX3Bpbj4sIDwmd2FuX2xlZF9waW4+Owo+ID4gPj4+ICsgICAg ICAgICAgICAgcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiA+ID4+PiArCj4gPiA+Pj4gKyAg ICAgICAgICAgICBsYW5fbGVkOiBsZWQtMCB7Cj4gPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAg IGdwaW9zID0gPCZncGlvMSBSS19QQTEgR1BJT19BQ1RJVkVfSElHSD47Cj4gPiA+Pj4gKyAgICAg ICAgICAgICAgICAgICAgIGxhYmVsID0gIm5hbm9waS1yNHM6Z3JlZW46bGFuIjsKPiA+ID4+PiAr ICAgICAgICAgICAgIH07Cj4gPiA+Pj4gKwo+ID4gPj4+ICsgICAgICAgICAgICAgc3lzX2xlZDog bGVkLTEgewo+ID4gPj4+ICsgICAgICAgICAgICAgICAgICAgICBncGlvcyA9IDwmZ3BpbzAgUktf UEI1IEdQSU9fQUNUSVZFX0hJR0g+Owo+ID4gPj4+ICsgICAgICAgICAgICAgICAgICAgICBsYWJl bCA9ICJuYW5vcGktcjRzOnJlZDpzeXMiOwo+ID4gPj4+ICsgICAgICAgICAgICAgICAgICAgICBk ZWZhdWx0LXN0YXRlID0gIm9uIjsKPiA+ID4+PiArICAgICAgICAgICAgIH07Cj4gPiA+Pj4gKwo+ ID4gPj4+ICsgICAgICAgICAgICAgd2FuX2xlZDogbGVkLTIgewo+ID4gPj4+ICsgICAgICAgICAg ICAgICAgICAgICBncGlvcyA9IDwmZ3BpbzEgUktfUEEwIEdQSU9fQUNUSVZFX0hJR0g+Owo+ID4g Pj4+ICsgICAgICAgICAgICAgICAgICAgICBsYWJlbCA9ICJuYW5vcGktcjRzOmdyZWVuOndhbiI7 Cj4gPiA+Pj4gKyAgICAgICAgICAgICB9Owo+ID4KPiA+IE5pdDogKGFwb2xvZ2llcyBmb3Igb3Zl cmxvb2tpbmcgaXQgYmVmb3JlKSB0aGVyZSBpc24ndCBhbiBvYnZpb3VzCj4gPiBkZWZpbml0aXZl IG9yZGVyIGZvciB0aGUgTEVEcywgYnV0IHRoZSBvcmRlciBoZXJlIGlzIGNlcnRhaW5seSBub3QK PiA+IGNvbnNpc3RlbnQgd2l0aCBhbnl0aGluZy4gVGhlIG1vc3QgbG9naWNhbCB3b3VsZCBwcm9i YWJseSBiZSBzeXMsIHdhbiwKPiAKPiBMb29rcyBsaWtlIGFscGhhYmV0aWNhbCBzb3J0IG9yZGVy IHRvIG1lIDstKQoKeWVwIC4uLiBsZWQtMCwgbGVkLTEsIGxlZC0yIGxvb2tzIHByZXR0eSBzb3J0 ZWQgOy0pCgpHZW5lcmFsbHkgSSdkIHByZWZlciBzb3J0aW5nIGJ5IG5vZGUtbmFtZXMgLi4uIGVz cGVjaWFsbHkgYXMgdGhlIHBoYW5kbGUKaXMgc29ydCBvZiBvcHRpb25hbCBmb3IgbW9zdCB0aGlu Z3MgLSBhbmQgdGhleSBzb21ldGltZXMgY29tZSBhbmQgZ28KaW4gZHQtZmlsZXMuCgoKSGVpa28K CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgt cm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hp cAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF8CC433DB for ; Mon, 15 Mar 2021 16:54:58 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A35964EFD for ; Mon, 15 Mar 2021 16:54:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A35964EFD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6+eYrp1DAjlhmkbeSGp+ozGPU5KaMIiheEpvF2/00sQ=; b=Oz8/GQ/Jl+6wna8G8Wt2jpm8i +Y5EyDqTX5UZdhKmdvr20ZqPSj0kwqrOhG5/EK1FpJbR3sxW4GI+g+2ADoCk90o81uY2G81fwooN7 VQBJog7COY4rRz1BWfg2ifzd3juEAy4If71M177gzhS63Kp0qSNi4Eu49ox3W9H6h7vK1ewjTLGWm q7AMqc8ITdtu/Z4j7/gHOTEHxQvwAuAJiEyPNqh6qOADVM/SDyohEdveaQ6B/a4IQ4AHubp6FEySY dYayDfV9J81SGf3w6BvsqN/d7+yWNIQFWWqOfx+dkG5sD/DEqwtyOAk4Zt7ONwF9kn+cESufhXihm ydmZAB3pQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLqSs-00GOuU-Qj; Mon, 15 Mar 2021 16:53:11 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLqSl-00GOtt-HQ; Mon, 15 Mar 2021 16:53:08 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLqSI-0001JB-1E; Mon, 15 Mar 2021 17:52:34 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Robin Murphy , Geert Uytterhoeven Cc: CN_SZTL , Rob Herring , Jagan Teki , Chen-Yu Tsai , Geert Uytterhoeven , David Bauer , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Johan Jonker , Michael Trimarchi , Marty Jones , Jensen Huang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , kernel test robot Subject: Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S Date: Mon, 15 Mar 2021 17:52:32 +0100 Message-ID: <17376355.sWSEgdgrri@diego> In-Reply-To: References: <20210313032515.12590-1-cnsztl@gmail.com> <67b314e7-92b9-8025-1a41-9b7da6ff2249@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_165306_488265_C03F0B34 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gTW9udGFnLCAxNS4gTcOkcnogMjAyMSwgMTc6Mzg6MzcgQ0VUIHNjaHJpZWIgR2VlcnQgVXl0 dGVyaG9ldmVuOgo+IEhpIFJvYmluLAo+IAo+IE9uIE1vbiwgTWFyIDE1LCAyMDIxIGF0IDU6MzIg UE0gUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4gd3JvdGU6Cj4gPiBPbiAyMDIx LTAzLTEzIDEzOjIyLCBDTl9TWlRMIHdyb3RlOgo+ID4gPiBSb2JpbiBNdXJwaHkgPHJvYmluLm11 cnBoeUBhcm0uY29tPiDkuo4yMDIx5bm0M+aciDEz5pel5ZGo5YWtIOS4i+WNiDc6NTXlhpnpgZPv vJoKPiA+ID4+Cj4gPiA+PiBPbiAyMDIxLTAzLTEzIDAzOjI1LCBUaWFubGluZyBTaGVuIHdyb3Rl Ogo+ID4gPj4+ICsgICAgIGdwaW8tbGVkcyB7Cj4gPiA+Pj4gKyAgICAgICAgICAgICBjb21wYXRp YmxlID0gImdwaW8tbGVkcyI7Cj4gPiA+Pj4gKyAgICAgICAgICAgICBwaW5jdHJsLTAgPSA8Jmxh bl9sZWRfcGluPiwgPCZzeXNfbGVkX3Bpbj4sIDwmd2FuX2xlZF9waW4+Owo+ID4gPj4+ICsgICAg ICAgICAgICAgcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiA+ID4+PiArCj4gPiA+Pj4gKyAg ICAgICAgICAgICBsYW5fbGVkOiBsZWQtMCB7Cj4gPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAg IGdwaW9zID0gPCZncGlvMSBSS19QQTEgR1BJT19BQ1RJVkVfSElHSD47Cj4gPiA+Pj4gKyAgICAg ICAgICAgICAgICAgICAgIGxhYmVsID0gIm5hbm9waS1yNHM6Z3JlZW46bGFuIjsKPiA+ID4+PiAr ICAgICAgICAgICAgIH07Cj4gPiA+Pj4gKwo+ID4gPj4+ICsgICAgICAgICAgICAgc3lzX2xlZDog bGVkLTEgewo+ID4gPj4+ICsgICAgICAgICAgICAgICAgICAgICBncGlvcyA9IDwmZ3BpbzAgUktf UEI1IEdQSU9fQUNUSVZFX0hJR0g+Owo+ID4gPj4+ICsgICAgICAgICAgICAgICAgICAgICBsYWJl bCA9ICJuYW5vcGktcjRzOnJlZDpzeXMiOwo+ID4gPj4+ICsgICAgICAgICAgICAgICAgICAgICBk ZWZhdWx0LXN0YXRlID0gIm9uIjsKPiA+ID4+PiArICAgICAgICAgICAgIH07Cj4gPiA+Pj4gKwo+ ID4gPj4+ICsgICAgICAgICAgICAgd2FuX2xlZDogbGVkLTIgewo+ID4gPj4+ICsgICAgICAgICAg ICAgICAgICAgICBncGlvcyA9IDwmZ3BpbzEgUktfUEEwIEdQSU9fQUNUSVZFX0hJR0g+Owo+ID4g Pj4+ICsgICAgICAgICAgICAgICAgICAgICBsYWJlbCA9ICJuYW5vcGktcjRzOmdyZWVuOndhbiI7 Cj4gPiA+Pj4gKyAgICAgICAgICAgICB9Owo+ID4KPiA+IE5pdDogKGFwb2xvZ2llcyBmb3Igb3Zl cmxvb2tpbmcgaXQgYmVmb3JlKSB0aGVyZSBpc24ndCBhbiBvYnZpb3VzCj4gPiBkZWZpbml0aXZl IG9yZGVyIGZvciB0aGUgTEVEcywgYnV0IHRoZSBvcmRlciBoZXJlIGlzIGNlcnRhaW5seSBub3QK PiA+IGNvbnNpc3RlbnQgd2l0aCBhbnl0aGluZy4gVGhlIG1vc3QgbG9naWNhbCB3b3VsZCBwcm9i YWJseSBiZSBzeXMsIHdhbiwKPiAKPiBMb29rcyBsaWtlIGFscGhhYmV0aWNhbCBzb3J0IG9yZGVy IHRvIG1lIDstKQoKeWVwIC4uLiBsZWQtMCwgbGVkLTEsIGxlZC0yIGxvb2tzIHByZXR0eSBzb3J0 ZWQgOy0pCgpHZW5lcmFsbHkgSSdkIHByZWZlciBzb3J0aW5nIGJ5IG5vZGUtbmFtZXMgLi4uIGVz cGVjaWFsbHkgYXMgdGhlIHBoYW5kbGUKaXMgc29ydCBvZiBvcHRpb25hbCBmb3IgbW9zdCB0aGlu Z3MgLSBhbmQgdGhleSBzb21ldGltZXMgY29tZSBhbmQgZ28KaW4gZHQtZmlsZXMuCgoKSGVpa28K CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA218C433E6 for ; Mon, 15 Mar 2021 16:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F53964F36 for ; Mon, 15 Mar 2021 16:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232437AbhCOQxW convert rfc822-to-8bit (ORCPT ); Mon, 15 Mar 2021 12:53:22 -0400 Received: from gloria.sntech.de ([185.11.138.130]:35506 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233468AbhCOQxG (ORCPT ); Mon, 15 Mar 2021 12:53:06 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLqSI-0001JB-1E; Mon, 15 Mar 2021 17:52:34 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Robin Murphy , Geert Uytterhoeven Cc: CN_SZTL , Rob Herring , Jagan Teki , Chen-Yu Tsai , Geert Uytterhoeven , David Bauer , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Johan Jonker , Michael Trimarchi , Marty Jones , Jensen Huang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , kernel test robot Subject: Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S Date: Mon, 15 Mar 2021 17:52:32 +0100 Message-ID: <17376355.sWSEgdgrri@diego> In-Reply-To: References: <20210313032515.12590-1-cnsztl@gmail.com> <67b314e7-92b9-8025-1a41-9b7da6ff2249@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Montag, 15. März 2021, 17:38:37 CET schrieb Geert Uytterhoeven: > Hi Robin, > > On Mon, Mar 15, 2021 at 5:32 PM Robin Murphy wrote: > > On 2021-03-13 13:22, CN_SZTL wrote: > > > Robin Murphy 于2021年3月13日周六 下午7:55写道： > > >> > > >> On 2021-03-13 03:25, Tianling Shen wrote: > > >>> + gpio-leds { > > >>> + compatible = "gpio-leds"; > > >>> + pinctrl-0 = <&lan_led_pin>, <&sys_led_pin>, <&wan_led_pin>; > > >>> + pinctrl-names = "default"; > > >>> + > > >>> + lan_led: led-0 { > > >>> + gpios = <&gpio1 RK_PA1 GPIO_ACTIVE_HIGH>; > > >>> + label = "nanopi-r4s:green:lan"; > > >>> + }; > > >>> + > > >>> + sys_led: led-1 { > > >>> + gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; > > >>> + label = "nanopi-r4s:red:sys"; > > >>> + default-state = "on"; > > >>> + }; > > >>> + > > >>> + wan_led: led-2 { > > >>> + gpios = <&gpio1 RK_PA0 GPIO_ACTIVE_HIGH>; > > >>> + label = "nanopi-r4s:green:wan"; > > >>> + }; > > > > Nit: (apologies for overlooking it before) there isn't an obvious > > definitive order for the LEDs, but the order here is certainly not > > consistent with anything. The most logical would probably be sys, wan, > > Looks like alphabetical sort order to me ;-) yep ... led-0, led-1, led-2 looks pretty sorted ;-) Generally I'd prefer sorting by node-names ... especially as the phandle is sort of optional for most things - and they sometimes come and go in dt-files. Heiko