From: patchwork-bot+bluetooth@kernel.org
To: Pauli Virtanen <pav@iki.fi>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] shared/gatt-db: fix crash on bad attribute index
Date: Mon, 27 Jan 2025 15:10:35 +0000 [thread overview]
Message-ID: <173799063523.3128680.16274968694858512912.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <efe1351374fceccbe4f1392fddab0d75e128a510.1737886528.git.pav@iki.fi>
Hello:
This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Sun, 26 Jan 2025 12:22:44 +0200 you wrote:
> In gatt_db_attribute_get_value(), avoid NULL pointer deref if attribute
> or db is in unexpected state and attrib at index-1 is missing.
>
> Fixes btmon -r crash, on a packet capture obtained with btmon -w after
> clearing BlueZ attributes & cache for the device:
>
> ==208213==ERROR: AddressSanitizer: SEGV on unknown address 0x00000000000c
> ==208213==The signal is caused by a READ memory access.
> ==208213==Hint: address points to the zero page.
> #0 0x5af4a6 in bt_uuid_to_uuid128 lib/uuid.c:65
> #1 0x5afd54 in bt_uuid_cmp lib/uuid.c:118
> #2 0x5d0dd2 in gatt_db_attribute_get_value src/shared/gatt-db.c:1663
> #3 0x56aeab in print_value monitor/att.c:158
> #4 0x56b80f in print_attribute monitor/att.c:207
> #5 0x5982f7 in print_handle monitor/att.c:4417
> #6 0x59b1b8 in print_write monitor/att.c:4598
> #7 0x59b796 in att_write_req monitor/att.c:4627
> #8 0x59e91e in att_packet monitor/att.c:4918
> #9 0x4f4847 in l2cap_frame monitor/l2cap.c:2567
> #10 0x4f6022 in l2cap_packet monitor/l2cap.c:2708
> #11 0x4a48f6 in packet_hci_acldata monitor/packet.c:12606
> #12 0x43952a in packet_monitor monitor/packet.c:4247
> #13 0x4170c9 in control_reader monitor/control.c:1517
> #14 0x402f76 in main monitor/main.c:277
>
> [...]
Here is the summary with links:
- [BlueZ] shared/gatt-db: fix crash on bad attribute index
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9f11c1817c56
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-01-27 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 10:22 [PATCH BlueZ] shared/gatt-db: fix crash on bad attribute index Pauli Virtanen
2025-01-26 11:31 ` [BlueZ] " bluez.test.bot
2025-01-27 15:10 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173799063523.3128680.16274968694858512912.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=pav@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.