From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC][PATCH 2/5 v2] drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() Date: Tue, 29 Nov 2016 08:50:44 +0200 Message-ID: <1738700.ehr6xDaTh1@avalon> References: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> <1480395884-5471-3-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3DB856E248 for ; Tue, 29 Nov 2016 06:50:31 +0000 (UTC) In-Reply-To: <1480395884-5471-3-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: lkml , dri-devel@lists.freedesktop.org, Wolfram Sang List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDI4IE5vdiAyMDE2 IDIxOjA0OjQxIEpvaG4gU3R1bHR6IHdyb3RlOgo+IEluIGNoYXNpbmcgZG93biBhIHByZXZpb3Vz IGlzc3VlIHdpdGggRURJRCBwcm9iaW5nIGZyb20gY2FsbGluZwo+IGRybV9oZWxwZXJfaHBkX2ly cV9ldmVudCgpIGZyb20gaXJxIGNvbnRleHQsIExhdXJlbnQgbm90aWNlZAo+IHRoYXQgdGhlIERS TSBkb2N1bWVudGF0aW9uIHN1Z2dlc3RzIHRoYXQKPiBkcm1fa21zX2hlbHBlcl9ob3RwbHVnX2V2 ZW50KCkgc2hvdWxkIGJlIHVzZWQgaW5zdGVhZC4KPiAKPiBUaHVzIHRoaXMgcGF0Y2ggcmVwbGFj ZXMgZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkgd2l0aAo+IGRybV9rbXNfaGVscGVyX2hvdHBs dWdfZXZlbnQoKS4KPiAKPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENj OiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPgo+IENjOiBXb2xmcmFtIFNh bmcgPHdzYStyZW5lc2FzQHNhbmctZW5naW5lZXJpbmcuY29tPgo+IENjOiBMYXJzLVBldGVyIENs YXVzZW4gPGxhcnNAbWV0YWZvby5kZT4KPiBDYzogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5w aW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gU2lnbmVkLW9mZi1ieTogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5v cmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5j IHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFf ZHJ2LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jIGlu ZGV4IGIzOGU3NDMuLjJjYWNhMGMKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL2Fkdjc1MTEvYWR2NzUxMV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv YWR2NzUxMS9hZHY3NTExX2Rydi5jCj4gQEAgLTQwNiw3ICs0MDYsNyBAQCBzdGF0aWMgdm9pZCBh ZHY3NTExX2lycV93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAgewo+ICAJc3RydWN0 IGFkdjc1MTEgKmFkdjc1MTEgPSBjb250YWluZXJfb2Yod29yaywgc3RydWN0IGFkdjc1MTEsIApp cnFfd29yayk7Cj4gCj4gLQlkcm1faGVscGVyX2hwZF9pcnFfZXZlbnQoYWR2NzUxMS0+Y29ubmVj dG9yLmRldik7Cj4gKwlkcm1fa21zX2hlbHBlcl9ob3RwbHVnX2V2ZW50KGFkdjc1MTEtPmNvbm5l Y3Rvci5kZXYpOwoKVGhhdCdzIG5pY2UsIGJ1dCB5b3UgbXVzdCBmaXJzdCB1cGRhdGUgYWR2NzUx MS0+Y29ubmVjdG9yLnN0YXR1cyAoYW5kIGFzIGFuIApvcHRpbWl6YXRpb24gb25seSBjYWxsIGRy bV9rbXNfaGVscGVyX2hvdHBsdWdfZXZlbnQoKSBpZiB0aGUgc3RhdHVzIGhhcyAKY2hhbmdlZCku Cgo+ICB9CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756130AbcK2Guj (ORCPT ); Tue, 29 Nov 2016 01:50:39 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:60141 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752510AbcK2Gub (ORCPT ); Tue, 29 Nov 2016 01:50:31 -0500 From: Laurent Pinchart To: John Stultz Cc: lkml , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , dri-devel@lists.freedesktop.org Subject: Re: [RFC][PATCH 2/5 v2] drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() Date: Tue, 29 Nov 2016 08:50:44 +0200 Message-ID: <1738700.ehr6xDaTh1@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1480395884-5471-3-git-send-email-john.stultz@linaro.org> References: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> <1480395884-5471-3-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, Thank you for the patch. On Monday 28 Nov 2016 21:04:41 John Stultz wrote: > In chasing down a previous issue with EDID probing from calling > drm_helper_hpd_irq_event() from irq context, Laurent noticed > that the DRM documentation suggests that > drm_kms_helper_hotplug_event() should be used instead. > > Thus this patch replaces drm_helper_hpd_irq_event() with > drm_kms_helper_hotplug_event(). > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: John Stultz > --- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index b38e743..2caca0c > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -406,7 +406,7 @@ static void adv7511_irq_work(struct work_struct *work) > { > struct adv7511 *adv7511 = container_of(work, struct adv7511, irq_work); > > - drm_helper_hpd_irq_event(adv7511->connector.dev); > + drm_kms_helper_hotplug_event(adv7511->connector.dev); That's nice, but you must first update adv7511->connector.status (and as an optimization only call drm_kms_helper_hotplug_event() if the status has changed). > } -- Regards, Laurent Pinchart