All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Muezerie <andremue@linux.microsoft.com>
To: andremue@linux.microsoft.com
Cc: anatoly.burakov@intel.com, bruce.richardson@intel.com,
	dev@dpdk.org, ian.stokes@intel.com, jochen.behrens@broadcom.com,
	vladimir.medvedkin@intel.com, stephen@networkplumber.org
Subject: [PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch
Date: Fri,  7 Feb 2025 09:41:08 -0800	[thread overview]
Message-ID: <1738950069-21059-1-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1735246770-731-1-git-send-email-andremue@linux.microsoft.com>

This patch avoids warnings like the ones below emitted by MSVC:

1)
../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
    result of 32-bit shift implicitly converted to 64 bits
    (was 64-bit shift intended?)

2)
../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
    signed/unsigned mismatch

The fix for (1) is to use 64-bit shifting when appropriate
(according to what the result is used for).

The fix for (2) is to explicitly cast the variables used in the
comparison.

v5:
 * rebase
 * use uint32_t instead of uint32, to better conform to DPDK standards
 * rename variable rqID to rq_id to better conform to DPDK standards
   and avoid checkpatch warning
 * use 2U instead of (uint32)2, which is shorter
 * simplify expression in meson.build using compiler id "gcc"

Andre Muezerie (1):
  drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

 drivers/net/intel/i40e/i40e_ethdev.c   | 22 +++++++++++-----------
 drivers/net/intel/iavf/iavf_ethdev.c   |  2 +-
 drivers/net/intel/iavf/iavf_rxtx.c     |  2 +-
 drivers/net/intel/iavf/iavf_vchnl.c    |  2 +-
 drivers/net/intel/ice/base/meson.build | 19 +++++++++++++------
 drivers/net/intel/ice/ice_dcf_sched.c  |  2 +-
 drivers/net/intel/ice/ice_ethdev.c     |  4 ++--
 drivers/net/intel/ice/ice_rxtx.c       |  2 +-
 drivers/net/intel/ixgbe/ixgbe_ethdev.c |  2 +-
 9 files changed, 32 insertions(+), 25 deletions(-)

--
2.47.2.vfs.0.1


  parent reply	other threads:[~2025-02-07 17:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 20:59 [PATCH] drivers_net: use 64-bit shift and avoid signed/unsigned mismatch Andre Muezerie
2025-01-06 10:54 ` Bruce Richardson
2025-01-06 21:16   ` Andre Muezerie
2025-01-06 21:16 ` [PATCH v2] drivers/net: " Andre Muezerie
2025-01-14 18:41   ` Stephen Hemminger
2025-01-14 21:08     ` Andre Muezerie
2025-01-14 23:30       ` Stephen Hemminger
2025-01-14 21:05 ` [PATCH v3] " Andre Muezerie
2025-02-05 18:35   ` Stephen Hemminger
2025-02-05 19:38     ` Andre Muezerie
2025-02-05 19:32 ` [PATCH v4] " Andre Muezerie
2025-02-06 11:07   ` Bruce Richardson
2025-02-07 15:46     ` Andre Muezerie
2025-02-07 15:56       ` Bruce Richardson
2025-02-07 17:47         ` Andre Muezerie
2025-02-07 17:56   ` Stephen Hemminger
2025-02-07 17:41 ` Andre Muezerie [this message]
2025-02-07 17:41   ` [PATCH v5 1/1] " Andre Muezerie
2025-02-07 19:00   ` [PATCH v5 0/1] use 64-bit shift, " Stephen Hemminger
2025-02-07 19:01   ` Stephen Hemminger
2025-02-10  9:35     ` Bruce Richardson
2025-02-10 16:07       ` Bruce Richardson
2025-02-10 20:32         ` Andre Muezerie
2025-02-10 21:02       ` Andre Muezerie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1738950069-21059-1-git-send-email-andremue@linux.microsoft.com \
    --to=andremue@linux.microsoft.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ian.stokes@intel.com \
    --cc=jochen.behrens@broadcom.com \
    --cc=stephen@networkplumber.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.