From: patchwork-bot+netdevbpf@kernel.org
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: chenhuacai@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, si.yanteng@linux.dev,
chris.chenfeiyang@gmail.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, fancer.lancer@gmail.com,
loongarch@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
horms@kernel.org, qiaochong@loongson.cn
Subject: Re: [PATCH net V2] net: stmmac: dwmac-loongson: Set correct {tx,rx}_fifo_size
Date: Thu, 13 Feb 2025 04:10:43 +0000 [thread overview]
Message-ID: <173941984332.756055.4356205354524855724.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250210134328.2755328-1-chenhuacai@loongson.cn>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 10 Feb 2025 21:43:28 +0800 you wrote:
> Now for dwmac-loongson {tx,rx}_fifo_size are uninitialised, which means
> zero. This means dwmac-loongson doesn't support changing MTU because in
> stmmac_change_mtu() it requires the fifo size be no less than MTU. Thus,
> set the correct tx_fifo_size and rx_fifo_size for it (16KB multiplied by
> queue counts).
>
> Here {tx,rx}_fifo_size is initialised with the initial value (also the
> maximum value) of {tx,rx}_queues_to_use. So it will keep as 16KB if we
> don't change the queue count, and will be larger than 16KB if we change
> (decrease) the queue count. However stmmac_change_mtu() still work well
> with current logic (MTU cannot be larger than 16KB for stmmac).
>
> [...]
Here is the summary with links:
- [net,V2] net: stmmac: dwmac-loongson: Set correct {tx,rx}_fifo_size
https://git.kernel.org/netdev/net-next/c/8dbf0c755645
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-02-13 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 13:43 [PATCH net V2] net: stmmac: dwmac-loongson: Set correct {tx,rx}_fifo_size Huacai Chen
2025-02-13 4:06 ` Jakub Kicinski
2025-02-13 4:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173941984332.756055.4356205354524855724.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=horms@kernel.org \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiaochong@loongson.cn \
--cc=si.yanteng@linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.