From: patchwork-bot+netdevbpf@kernel.org
To: Pierre Riteau <pierre@stackhpc.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net/sched: cls_api: fix error handling causing NULL dereference
Date: Sat, 15 Feb 2025 17:30:28 +0000 [thread overview]
Message-ID: <173964062887.2306719.12280700542530896756.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250213223610.320278-1-pierre@stackhpc.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 13 Feb 2025 23:36:10 +0100 you wrote:
> tcf_exts_miss_cookie_base_alloc() calls xa_alloc_cyclic() which can
> return 1 if the allocation succeeded after wrapping. This was treated as
> an error, with value 1 returned to caller tcf_exts_init_ex() which sets
> exts->actions to NULL and returns 1 to caller fl_change().
>
> fl_change() treats err == 1 as success, calling tcf_exts_validate_ex()
> which calls tcf_action_init() with exts->actions as argument, where it
> is dereferenced.
>
> [...]
Here is the summary with links:
- [net] net/sched: cls_api: fix error handling causing NULL dereference
https://git.kernel.org/netdev/net/c/071ed42cff4f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-02-15 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 22:36 [PATCH net] net/sched: cls_api: fix error handling causing NULL dereference Pierre Riteau
2025-02-14 12:43 ` Michal Swiatkowski
2025-02-14 14:21 ` Pierre Riteau
2025-02-14 14:38 ` Pierre Riteau
2025-02-15 17:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173964062887.2306719.12280700542530896756.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pierre@stackhpc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.