From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Farnsworth Subject: Re: [PATCH] drm/dp: Use large transactions for I2C over AUX Date: Wed, 28 Jan 2015 10:45:13 +0000 Message-ID: <1740711.1El05qIoQL@f19simon> References: <1422285768-1655-1-git-send-email-simon.farnsworth@onelan.co.uk> <20150128091022.GF4764@phenom.ffwll.local> <87y4onqmfl.fsf@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0303817382==" Return-path: Received: from claranet-outbound-smtp06.uk.clara.net (claranet-outbound-smtp06.uk.clara.net [195.8.89.39]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E2A96E402 for ; Wed, 28 Jan 2015 02:45:49 -0800 (PST) In-Reply-To: <87y4onqmfl.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: dri-devel@lists.freedesktop.org, Thierry Reding List-Id: dri-devel@lists.freedesktop.org --===============0303817382== Content-Type: multipart/signed; boundary="nextPart1521581.Plc37GPrVS"; micalg="pgp-sha1"; protocol="application/pgp-signature" --nextPart1521581.Plc37GPrVS Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" On Wednesday 28 January 2015 11:33:34 Jani Nikula wrote: > On Wed, 28 Jan 2015, Daniel Vetter wrote: > > On Wed, Jan 28, 2015 at 10:59:06AM +0200, Jani Nikula wrote: > >> On Tue, 27 Jan 2015, Ville Syrj=E4l=E4 wrote: =2D-snip-- > >> > I made the msg size configurable via a module param just to help= me test > >> > this stuff, but I'm thinking we might want to upstream that just= to make > >> > it easier to try smaller message sizes if/when people encounter = problematic > >> > sinks/dongles. > >>=20 > >> How about just letting that happen first, to see if and how the pr= oblems > >> occur? If there's a pattern, maybe we can fall back to 1-byte tran= sfers > >> in those cases (or even add OUI based quirks). I've grown really > >> hesitant about adding new module parameters, they are ABI we can't= > >> easily remove/regress once added. > > > > module_param_debug takes care of any such risks imo. >=20 > No such thing, maybe you mean module_param_unsafe? >=20 > Jani. Changing to module_param_unsafe is trivial. That would taint the kernel= if you play with it, hopefully making it clear that this is not permanent = ABI. I'm now seeing the Bizlink adapters fail after about 45 seconds of isochronous link up, so it'll be a few days before I do a v4 of this pa= tch, as I need Datapath's assistance analysing the differences in behaviour between us and Windows). =2D-=20 Simon Farnsworth Software Engineer ONELAN Ltd http://www.onelan.com --nextPart1521581.Plc37GPrVS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABAgAGBQJUyL29AAoJEOsKZy3xM+c7nSwH/1hhc2XQWqZNr2H+yWGAqG7R l9iGqqtxzbLYcNMpEi2B+Z+u0/3cHuPrpcVmlft2gMhjfTl8emQ3QZMJtvBrvHqy Ky44BDRNA4nJWz7ARDiAvXKLPZIYPt9dtnQeLLxbO9YD9Leb4FL+ixr2wqfyurL0 ErJBHPtxGJMzGpvWgUeKdh/9MJ6RXpEIg89I7Kje3qWBJHSA9z+5M1CKWPCo3Ost YO1dIePy/RJ5eN8cYBdsg8hSMpqKTcF/Uf1ExYcc/xfcAn0oDuwvYniswyPdG6Wy 1YpFj5jjGgyS2d94yL3Jb60ZeV2JeNexDeoTblgFNuVNsYL9b8L90yOKnpiYwCc= =nnZt -----END PGP SIGNATURE----- --nextPart1521581.Plc37GPrVS-- --===============0303817382== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0303817382==--