From: David Howells <dhowells@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Leonardo Chiquitto <leonardo.lists@gmail.com>,
Ian Kent <raven@themaw.net>, Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
autofs@linux.kernel.org
Subject: Re: [PATCH] vfs: automount should ignore LOOKUP_FOLLOW
Date: Mon, 05 Sep 2011 17:37:39 +0100 [thread overview]
Message-ID: <17416.1315240659@redhat.com> (raw)
In-Reply-To: <87liu37z3x.fsf@tucsk.pomaz.szeredi.hu>
Miklos Szeredi <miklos@szeredi.hu> wrote:
> After 2.6.38, with the introduction of the ->d_automount()
> infrastructure, stat(2) and others would start triggering automount
> while lstat(2), etc. still would not. This is a regression and a
> userspace ABI change.
It doesn't necessarily mean it's wrong. The main class of program that needs
to be prevented from automounting are things that do bulk stat'ing (e.g. ls) -
and they should probably be doing lstat() anyway.
> + /* We don't want to mount if someone's just doing a stat -
> + * unless they're stat'ing a directory and appended a '/' to
> + * the name.
Btw, line length is 80 chars. This comment could easily use one fewer line.
If you use emacs you can do:
ESC 7 9 C-x f
to set the right margin and then:
M-q
whilst the cursor is in the comment paragraph to be rearranged and it will
'fill' the paragraph to 79 characters.
David
next prev parent reply other threads:[~2011-09-05 16:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 16:06 [PATCH] vfs: automount should ignore LOOKUP_FOLLOW Miklos Szeredi
2011-09-05 16:37 ` David Howells [this message]
2011-09-05 17:02 ` Miklos Szeredi
2011-09-06 3:53 ` Ian Kent
2011-09-06 4:03 ` Ian Kent
2011-09-06 8:09 ` Miklos Szeredi
2011-09-06 14:38 ` Ian Kent
2011-09-06 15:39 ` Miklos Szeredi
2011-09-08 12:36 ` Ian Kent
2011-09-08 13:38 ` Miklos Szeredi
2011-09-08 17:42 ` Linus Torvalds
2011-09-08 19:50 ` Al Viro
2011-09-08 20:19 ` Linus Torvalds
2011-09-08 21:54 ` Al Viro
2011-09-09 3:37 ` Ian Kent
2011-09-09 3:33 ` Ian Kent
2011-09-09 3:18 ` Ian Kent
2011-09-22 12:29 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17416.1315240659@redhat.com \
--to=dhowells@redhat.com \
--cc=autofs@linux.kernel.org \
--cc=leonardo.lists@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=raven@themaw.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.