From: Tomasz Figa <tomasz.figa@gmail.com>
To: Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
wim@iguana.be, t.figa@samsung.com, devicetree@vger.kernel.org,
dianders@chromium.org, linux-watchdog@vger.kernel.org,
cpgs@samsung.com, sachin.kamat@linaro.org
Subject: Re: [PATCH V6 2/3] ARM: dts: add watchdog device nodes for Exynos5250 and Exynos5420
Date: Sun, 10 Nov 2013 20:27:30 +0100 [thread overview]
Message-ID: <1741749.lLZhaDvyuy@flatron> (raw)
In-Reply-To: <1383825078-24515-3-git-send-email-l.krishna@samsung.com>
Hi Leela,
On Thursday 07 of November 2013 17:21:17 Leela Krishna Amudala wrote:
> Adds watchdog device nodes to the DT device list for Exynos5250 and Exynos5420
s/add/update/ since there was already a device tree node in exynos5.dtsi.
Also, patch description should mention all the changes done in the patch
and I see more changes than described by your description. This patch also
makes the watchdog node enabled by default.
Otherwise the patch looks good.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-11-10 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 11:51 [PATCH V6 0/3] Add watchdog DT nodes and use syscon regmap interfac to configure pmu registers Leela Krishna Amudala
2013-11-07 11:51 ` [PATCH V6 1/3] ARM: dts: Add pmu sysreg node to Exynos5 dtsi file Leela Krishna Amudala
2013-11-10 19:23 ` Tomasz Figa
2013-11-07 11:51 ` [PATCH V6 2/3] ARM: dts: add watchdog device nodes for Exynos5250 and Exynos5420 Leela Krishna Amudala
2013-11-10 19:27 ` Tomasz Figa [this message]
2013-11-07 11:51 ` [PATCH V6 3/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register Leela Krishna Amudala
2013-11-10 19:13 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1741749.lLZhaDvyuy@flatron \
--to=tomasz.figa@gmail.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.