From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794064454; b=ww+6S5PhU/WyCYhErSll7rSDzaaBI38LoVDf316L3GdRTAxmrtQtPvr954plDdDVEEYQ lyP9nqfKmypsRcmPYPKIm60qn0zKWv44ER2ErZLwNPuNIo2aP4TcqlGaOOJoK7XAf1NRg MTIG+txxPmXef2/i7uxvPHp9ZL5Lmx0GU8e+ny3QbMZozNNRKHfxi2LSiVV5EiMNqNZJW RlPLPuF4ZswRXZU6vOw94Y4lfseXzZZLDtB13aoW7VPISxQomG3C6mH9kxY4EZNawqrbI Xz0YM0q4h9bjE5dDyAcSfXktF4vs/9/im9Pnm8LmS10WwQmFmpWCdU+urf1GhPuvZdA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794064454; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=AM2+ROYz6zHyjM9qbGIPn3yG3QGJhtGkC3tgAmCv0WE=; b=OPRXsE9pKOSVS0HS+A8mqMHAOJy30Zok88fHob6bwWW/A8C8Y06OsiI0FLFygCIx4/rb Gmn0BoR3fVb7lP/UBdtWsvTN4Uj7WJvjzWIw1U3GnyPqiYYyR9H9pS0fWvaGBud2IASgA sT/C3/lGoeSWH34QSio6Ca2PDc4L2TcpX5V2xSlSUrBPsSJA8g1Z2w00FLQlCZLrXPbsl 7YnbrmrqoiF5g6zWuPCd5H8pKMSNdO5dE6g6dd7wDqme0cLk7PBz/c5g/Z2kJdQNp1lLn iwT8rY7Yx+j1yb0ENSTj7I2uflRjtuPPAEB8rcyiQbCFrmTdVb1mhLs0grtfVX6pUWQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=ANlytgWy; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2699606C004; Sat, 7 Nov 2026 15:14:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B2699606C004 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=ANlytgWy DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=AM2+ROYz6zHyjM9qbGIPn3yG3QGJhtGkC3tgAmCv0WE=; b=ANlytgWyNbxksTlctB1IPmnOyw eVN8ZWy4Jk9Woz7x9MdiIUjtWgomTH3Zh3oLQLaWjyNesR8IAVyvb9htWNi0VjAJl5dImAwJ/2jhH 4SO1BZKBOHp6QrMer/QOFmpOaPFFmv0FfchFRa2BZWwnH4tkavdWhHimHgzkzP6VM7iHox0J22vWp CrjI2E3FIyQQDpA8jkpGXZDEZPO/8UBflGmtaFZUzzQtUCarH4Chp36byFQyTGz9cvS+y18IMLX7B xdmvp03YJGwy2H0Kfg7A4+TskVQ9C4X4gxt60WeIJ41YdJhAgQXIiZsK1Mb3jikC525CkgbDGm8N9 oVk5Kxuw==; From: Heiko Stuebner To: rafael@kernel.org, Daniel Lezcano Cc: Daniel Lezcano , Shuah Khan , Manaf Meethalavalappu Pallikunhi , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 6/6] powercap: dtpm: Add RK3588 hierarchy Date: Sat, 07 Nov 2026 16:14:06 +0100 Message-ID: <17421425.hlxOUv9cDv@phil> In-Reply-To: <973998404b628e5a995a06fbd0febce0802f79bd.1793666444.git.daniel.lezcano@oss.qualcomm.com> References: <973998404b628e5a995a06fbd0febce0802f79bd.1793666444.git.daniel.lezcano@oss.qualcomm.com> X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Daniel, Am Dienstag, 3. November 2026, 05:48:20 Mitteleurop=C3=A4ische Normalzeit s= chrieb Daniel Lezcano: > The RK3588 has three CPU frequency domains, with CPUs grouped into > three cpufreq policies. >=20 > Add a DTPM hierarchy for the RK3588 with one CPU node per cpufreq > policy, represented by cpu@0, cpu@400 and cpu@600. Group the three CPU > domains under a virtual package node attached to the RK3588 root node. >=20 > Add the RK3588 compatible to the Rockchip DTPM match table to select > the new hierarchy. >=20 > Signed-off-by: Daniel Lezcano > Reviewed-by: Lukasz Luba [...] > static struct of_device_id __initdata rockchip_dtpm_match_table[] =3D { > { .compatible =3D "rockchip,rk3399", .data =3D &rk3399_hierarchy }, > + { .compatible =3D "rockchip,rk3588", .data =3D &rk3588_hierarchy }, > {}, > }; the change itself looks good for the RK3588 (without variants), so Reviewed-by: Heiko Stuebner but support for the family is sort of incomplete :-) We have =2D the rockchip,rk3588s (same as the rk3588 in terms of cores, but different compatible - see all the rk3588s-* boards) =2D the RK3582 ... with a compatible of "rockchip,rk3582", "rockchip,rk3588s" Because this is some sort of chip with production defects where two _random_ big do not work or so and get disabled by firmware see [0] and marks them as "fail" So as I said the change alone is fine, but there are additional variants to maybe figure out in the future. Heiko [0] https://patchwork.ozlabs.org/project/uboot/cover/20250810222644.4095072= =2D1-jonas@kwiboo.se/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEE69606A9E7 for ; Sat, 7 Nov 2026 15:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=u4KdfAw7; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=ANlytgWy DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=08dJpvBlceLri1+yKwBp7fVRi+VrQivwN+Be84hCVA0=; b=u4KdfAw7SMvdhZxhAopac6wSCs 767bBkCvCQDZ+5PTcMpBD+9J/p3Hya1JFNKOMU2lt8IUAJuv1N6w38Bv71Qe4iTWrVdUpTIccW1GR W4FCGT+Uz1GB5H3Fv0X8yH2fnLvQSd7WknKNDva+Mg7dMEMwrRJCfIlWj8OzzBFRT4KFJE8sPxEMk nlCel2SOZ/ZVhrgeGVYAr6UCngbEtlwDNi6WVpMkV3q3YUDIMnzw7IiI4KHxzgaDJhB4mDI2K4J1d YdUVqrnj07tB5euxC7MXNW0CGgQ/PP8ud+bLH+MSw0GP2afUcLxNOMiCLzz0+FZYryjM37lUpGAtI xRZo4q9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPi7T-0000000Esvt-1S39; Sat, 07 Nov 2026 15:14:15 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPi7R-0000000EsvA-0WKf; Sat, 07 Nov 2026 15:14:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=AM2+ROYz6zHyjM9qbGIPn3yG3QGJhtGkC3tgAmCv0WE=; b=ANlytgWyNbxksTlctB1IPmnOyw eVN8ZWy4Jk9Woz7x9MdiIUjtWgomTH3Zh3oLQLaWjyNesR8IAVyvb9htWNi0VjAJl5dImAwJ/2jhH 4SO1BZKBOHp6QrMer/QOFmpOaPFFmv0FfchFRa2BZWwnH4tkavdWhHimHgzkzP6VM7iHox0J22vWp CrjI2E3FIyQQDpA8jkpGXZDEZPO/8UBflGmtaFZUzzQtUCarH4Chp36byFQyTGz9cvS+y18IMLX7B xdmvp03YJGwy2H0Kfg7A4+TskVQ9C4X4gxt60WeIJ41YdJhAgQXIiZsK1Mb3jikC525CkgbDGm8N9 oVk5Kxuw==; From: Heiko Stuebner To: rafael@kernel.org, Daniel Lezcano Cc: Daniel Lezcano , Shuah Khan , Manaf Meethalavalappu Pallikunhi , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 6/6] powercap: dtpm: Add RK3588 hierarchy Date: Sat, 07 Nov 2026 16:14:06 +0100 Message-ID: <17421425.hlxOUv9cDv@phil> In-Reply-To: <973998404b628e5a995a06fbd0febce0802f79bd.1793666444.git.daniel.lezcano@oss.qualcomm.com> References: <973998404b628e5a995a06fbd0febce0802f79bd.1793666444.git.daniel.lezcano@oss.qualcomm.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_071413_166406_C2125702 X-CRM114-Status: GOOD ( 12.31 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 SGkgRGFuaWVsLAoKQW0gRGllbnN0YWcsIDMuIE5vdmVtYmVyIDIwMjYsIDA1OjQ4OjIwIE1pdHRl bGV1cm9ww6Rpc2NoZSBOb3JtYWx6ZWl0IHNjaHJpZWIgRGFuaWVsIExlemNhbm86Cj4gVGhlIFJL MzU4OCBoYXMgdGhyZWUgQ1BVIGZyZXF1ZW5jeSBkb21haW5zLCB3aXRoIENQVXMgZ3JvdXBlZCBp bnRvCj4gdGhyZWUgY3B1ZnJlcSBwb2xpY2llcy4KPiAKPiBBZGQgYSBEVFBNIGhpZXJhcmNoeSBm b3IgdGhlIFJLMzU4OCB3aXRoIG9uZSBDUFUgbm9kZSBwZXIgY3B1ZnJlcQo+IHBvbGljeSwgcmVw cmVzZW50ZWQgYnkgY3B1QDAsIGNwdUA0MDAgYW5kIGNwdUA2MDAuIEdyb3VwIHRoZSB0aHJlZSBD UFUKPiBkb21haW5zIHVuZGVyIGEgdmlydHVhbCBwYWNrYWdlIG5vZGUgYXR0YWNoZWQgdG8gdGhl IFJLMzU4OCByb290IG5vZGUuCj4gCj4gQWRkIHRoZSBSSzM1ODggY29tcGF0aWJsZSB0byB0aGUg Um9ja2NoaXAgRFRQTSBtYXRjaCB0YWJsZSB0byBzZWxlY3QKPiB0aGUgbmV3IGhpZXJhcmNoeS4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgTGV6Y2FubyA8ZGFuaWVsLmxlemNhbm9Ab3NzLnF1 YWxjb21tLmNvbT4KPiBSZXZpZXdlZC1ieTogTHVrYXN6IEx1YmEgPGx1a2Fzei5sdWJhQGFybS5j b20+CgpbLi4uXQoKPiAgc3RhdGljIHN0cnVjdCBvZl9kZXZpY2VfaWQgX19pbml0ZGF0YSByb2Nr Y2hpcF9kdHBtX21hdGNoX3RhYmxlW10gPSB7Cj4gIAl7IC5jb21wYXRpYmxlID0gInJvY2tjaGlw LHJrMzM5OSIsIC5kYXRhID0gJnJrMzM5OV9oaWVyYXJjaHkgfSwKPiArCXsgLmNvbXBhdGlibGUg PSAicm9ja2NoaXAscmszNTg4IiwgLmRhdGEgPSAmcmszNTg4X2hpZXJhcmNoeSB9LAo+ICAJe30s Cj4gIH07Cgp0aGUgY2hhbmdlIGl0c2VsZiBsb29rcyBnb29kIGZvciB0aGUgUkszNTg4ICh3aXRo b3V0IHZhcmlhbnRzKSwgc28KClJldmlld2VkLWJ5OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250 ZWNoLmRlPgoKCmJ1dCBzdXBwb3J0IGZvciB0aGUgZmFtaWx5IGlzIHNvcnQgb2YgaW5jb21wbGV0 ZSA6LSkKV2UgaGF2ZQotIHRoZSByb2NrY2hpcCxyazM1ODhzIChzYW1lIGFzIHRoZSByazM1ODgg aW4gdGVybXMgb2YgY29yZXMsCiAgYnV0IGRpZmZlcmVudCBjb21wYXRpYmxlIC0gc2VlIGFsbCB0 aGUgcmszNTg4cy0qIGJvYXJkcykKLSB0aGUgUkszNTgyIC4uLiB3aXRoIGEgY29tcGF0aWJsZSBv ZgogICJyb2NrY2hpcCxyazM1ODIiLCAicm9ja2NoaXAscmszNTg4cyIKICBCZWNhdXNlIHRoaXMg aXMgc29tZSBzb3J0IG9mIGNoaXAgd2l0aCBwcm9kdWN0aW9uIGRlZmVjdHMKICB3aGVyZSB0d28g X3JhbmRvbV8gYmlnIGRvIG5vdCB3b3JrIG9yIHNvIGFuZCBnZXQgZGlzYWJsZWQKICBieSBmaXJt d2FyZSBzZWUgWzBdIGFuZCBtYXJrcyB0aGVtIGFzICJmYWlsIgoKU28gYXMgSSBzYWlkIHRoZSBj aGFuZ2UgYWxvbmUgaXMgZmluZSwgYnV0IHRoZXJlIGFyZSBhZGRpdGlvbmFsIHZhcmlhbnRzCnRv IG1heWJlIGZpZ3VyZSBvdXQgaW4gdGhlIGZ1dHVyZS4KCgpIZWlrbwoKCgpbMF0gaHR0cHM6Ly9w YXRjaHdvcmsub3psYWJzLm9yZy9wcm9qZWN0L3Vib290L2NvdmVyLzIwMjUwODEwMjIyNjQ0LjQw OTUwNzItMS1qb25hc0Brd2lib28uc2UvCgoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJv Y2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo=