From: Oliver Upton <oliver.upton@linux.dev>
To: kvmarm@lists.linux.dev, Will Deacon <will@kernel.org>
Cc: Oliver Upton <oliver.upton@linux.dev>,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
Marc Zyngier <maz@kernel.org>,
Quentin Perret <qperret@google.com>
Subject: Re: [PATCH] KVM: arm64: Tear down vGIC on failed vCPU creation
Date: Tue, 18 Mar 2025 00:47:36 -0700 [thread overview]
Message-ID: <174228404857.1652170.4192050516109561246.b4-ty@linux.dev> (raw)
In-Reply-To: <20250314133409.9123-1-will@kernel.org>
On Fri, 14 Mar 2025 13:34:09 +0000, Will Deacon wrote:
> If kvm_arch_vcpu_create() fails to share the vCPU page with the
> hypervisor, we propagate the error back to the ioctl but leave the
> vGIC vCPU data initialised. Note only does this leak the corresponding
> memory when the vCPU is destroyed but it can also lead to use-after-free
> if the redistributor device handling tries to walk into the vCPU.
>
> Add the missing cleanup to kvm_arch_vcpu_create(), ensuring that the
> vGIC vCPU structures are destroyed on error.
>
> [...]
Applied to next, thanks!
[1/1] KVM: arm64: Tear down vGIC on failed vCPU creation
https://git.kernel.org/kvmarm/kvmarm/c/250f25367b58
--
Best,
Oliver
prev parent reply other threads:[~2025-03-18 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 13:34 [PATCH] KVM: arm64: Tear down vGIC on failed vCPU creation Will Deacon
2025-03-16 10:38 ` Marc Zyngier
2025-03-18 7:47 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174228404857.1652170.4192050516109561246.b4-ty@linux.dev \
--to=oliver.upton@linux.dev \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=qperret@google.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.