Re: [PATCH 2/2] ARM: shmobile: r8a7790: Wait for status on all MSTP clocks

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Simon,

On Thursday 31 October 2013 14:36:06 Simon Horman wrote:
> On Tue, Oct 29, 2013 at 06:13:54PM +0100, Laurent Pinchart wrote:
> > From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> > 
> > When enabling a module clock by clearing its bit in the MSTP control
> > register, the CPG requires waiting for the status register to signal
> > that the clock has started. Failure to do so will result in returning
> > from the clk_enable() call with the clock potientially still disabled,
> > leading to various race conditions and difficult to debug errors.
> > 
> > Enable status wait for all MSTP clocks on the r8a7790.
> 
> Is this patch independent of patch 1 of this series?

Yes it is. The SH_CLK_MSTP32_STS macro is defined in patch 1/2.

> > Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/mach-shmobile/clock-r8a7790.c | 86 ++++++++++++++++-------------
> >  1 file changed, 47 insertions(+), 39 deletions(-)

-- 
Regards,

Laurent Pinchart