From: patchwork-bot+netdevbpf@kernel.org
To: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net-next] net: phy: fix genphy_c45_eee_is_active() for disabled EEE
Date: Fri, 21 Mar 2025 20:50:36 +0000 [thread overview]
Message-ID: <174259023600.2618986.2107650390226882487.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <E1ttmWN-0077Mb-Q6@rmk-PC.armlinux.org.uk>
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 16 Mar 2025 11:51:11 +0000 you wrote:
> Commit 809265fe96fe ("net: phy: c45: remove local advertisement
> parameter from genphy_c45_eee_is_active") stopped reading the local
> advertisement from the PHY earlier in this development cycle, which
> broke "ethtool --set-eee ethX eee off".
>
> When ethtool is used to set EEE off, genphy_c45_eee_is_active()
> indicates that EEE was active if the link partner reported an
> advertisement, which causes phylib to set phydev->enable_tx_lpi on
> link up, despite our local advertisement in hardware being empty.
> However, phydev->advertising_eee is preserved while EEE is turned off,
> which leads to genphy_c45_eee_is_active() incorrectly reporting that
> EEE is active.
>
> [...]
Here is the summary with links:
- [net-next] net: phy: fix genphy_c45_eee_is_active() for disabled EEE
https://git.kernel.org/netdev/net-next/c/4b9235a880f1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-03-21 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 11:51 [PATCH net-next] net: phy: fix genphy_c45_eee_is_active() for disabled EEE Russell King (Oracle)
2025-03-17 21:35 ` Andrew Lunn
2025-03-21 20:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174259023600.2618986.2107650390226882487.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.