All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/4] libgfs2: Superblock building and	writing improvements
Date: Mon, 17 Feb 2014 10:12:40 -0500 (EST)	[thread overview]
Message-ID: <1743331882.643920.1392649960679.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1392648480-5085-1-git-send-email-anprice@redhat.com>

----- Original Message -----
| build_sb was creating the sb, setting its fields from an sdp and then
| writing it, and also zeroing the gap before the sb on the device in a
| block-by-block way using buffer_heads.
| 
| This patch splits the build_sb function into lgfs2_sb_init and
| lgfs2_sb_write which operate on gfs2_sb structures instead of gfs2_sbds.
| lgfs2_sb_write now uses pwritev to zero the initial blocks and write the
| sb to an fd.
| 
| get_random_bytes has been moved into structures.c and made static as
| only lgfs2_sb_init now uses it.
| 
| Signed-off-by: Andrew Price <anprice@redhat.com>
| ---

Hi,

All four patches look good to me. ACK.

Bob Peterson
Red Hat File Systems



  parent reply	other threads:[~2014-02-17 15:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 14:47 [Cluster-devel] [PATCH 1/4] libgfs2: Superblock building and writing improvements Andrew Price
2014-02-17 14:47 ` [Cluster-devel] [PATCH 2/4] gfs2-utils: Ensure sb_uuid uses are guarded Andrew Price
2014-02-17 14:47 ` [Cluster-devel] [PATCH 3/4] libgfs2: Add support for new leaf hint fields Andrew Price
2014-02-18 10:36   ` Steven Whitehouse
2014-02-18 11:02     ` Andrew Price
2014-02-17 14:48 ` [Cluster-devel] [PATCH 4/4] mkfs.gfs2: Remove a dead structure Andrew Price
2014-02-17 15:12 ` Bob Peterson [this message]
2014-02-25  3:15 ` [Cluster-devel] [PATCH] fsck.gfs2: special handling for gfs1 sb update Abhijith Das
2014-02-25 12:20   ` Andrew Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1743331882.643920.1392649960679.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.