All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, netdev@vger.kernel.org, eric.dumazet@gmail.com,
	syzbot+fae49d997eb56fa7c74d@syzkaller.appspotmail.com,
	marcelo.leitner@gmail.com, lucien.xin@gmail.com
Subject: Re: [PATCH net] sctp: add mutual exclusion in proc_sctp_do_udp_port()
Date: Wed, 02 Apr 2025 23:40:33 +0000	[thread overview]
Message-ID: <174363723326.1716091.14559512719175692970.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250331091532.224982-1-edumazet@google.com>

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 31 Mar 2025 09:15:32 +0000 you wrote:
> We must serialize calls to sctp_udp_sock_stop() and sctp_udp_sock_start()
> or risk a crash as syzbot reported:
> 
> Oops: general protection fault, probably for non-canonical address 0xdffffc000000000d: 0000 [#1] SMP KASAN PTI
> KASAN: null-ptr-deref in range [0x0000000000000068-0x000000000000006f]
> CPU: 1 UID: 0 PID: 6551 Comm: syz.1.44 Not tainted 6.14.0-syzkaller-g7f2ff7b62617 #0 PREEMPT(full)
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
>  RIP: 0010:kernel_sock_shutdown+0x47/0x70 net/socket.c:3653
> Call Trace:
>  <TASK>
>   udp_tunnel_sock_release+0x68/0x80 net/ipv4/udp_tunnel_core.c:181
>   sctp_udp_sock_stop+0x71/0x160 net/sctp/protocol.c:930
>   proc_sctp_do_udp_port+0x264/0x450 net/sctp/sysctl.c:553
>   proc_sys_call_handler+0x3d0/0x5b0 fs/proc/proc_sysctl.c:601
>   iter_file_splice_write+0x91c/0x1150 fs/splice.c:738
>   do_splice_from fs/splice.c:935 [inline]
>   direct_splice_actor+0x18f/0x6c0 fs/splice.c:1158
>   splice_direct_to_actor+0x342/0xa30 fs/splice.c:1102
>   do_splice_direct_actor fs/splice.c:1201 [inline]
>   do_splice_direct+0x174/0x240 fs/splice.c:1227
>   do_sendfile+0xafd/0xe50 fs/read_write.c:1368
>   __do_sys_sendfile64 fs/read_write.c:1429 [inline]
>   __se_sys_sendfile64 fs/read_write.c:1415 [inline]
>   __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1415
>   do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
> 
> [...]

Here is the summary with links:
  - [net] sctp: add mutual exclusion in proc_sctp_do_udp_port()
    https://git.kernel.org/netdev/net/c/10206302af85

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2025-04-02 23:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31  9:15 [PATCH net] sctp: add mutual exclusion in proc_sctp_do_udp_port() Eric Dumazet
2025-03-31 15:54 ` Xin Long
2025-03-31 16:11   ` Eric Dumazet
2025-03-31 18:50     ` David Laight
2025-04-01  0:22       ` Xin Long
2025-04-01  0:15     ` Xin Long
2025-04-02 23:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174363723326.1716091.14559512719175692970.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+fae49d997eb56fa7c74d@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.