Re: [PATCH v2] hw/block: Add migration support for pflash_cfi02.c

["Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>]

On 27/8/26 21:39, Om Barkare wrote:
> From: OmBarkare <ombarkare123@gmail.com>
> 
> Device did not have migration support, which would result in its
> internal state being lost during migration or saves.
> 
> Add VMStateDescription to serialize state and set memory regions
> romd_mode to rom_mode field in post load hook
> 
> total_sectors was changed from uint32_t to int32_t to satisfy the
> VMSTATE_BITMAP macro's _field_size argument, but that is OK because
> it's a value is calculated using the size of the flash and it will
> never be large enough to overflow int32_t
> 
> The only boards using pflash_cfi02 are the sh4 r2d and
> the arm canon-a1100, musicpal and xilinx-zynq-a9
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4157
> 
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Om Barkare <ombarkare123@gmail.com>
> ---
> Changes since v1
> - Add "bypass" to vmstate
> - Remove the vmstate subsection and add these states to the main vmstate
>    instead
> - Remove the pflash_erase_sector_needed function which was related to
>    the subsection as no longer needed
> 
>   hw/block/pflash_cfi02.c | 52 ++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 51 insertions(+), 1 deletion(-)

Queued, thanks!