From: patchwork-bot+netdevbpf@kernel.org
To: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Cc: nbd@nbd.name, sean.wang@mediatek.com, lorenzo@kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, biao.huang@mediatek.com,
ot_yinghua.pan@mediatek.com, brgl@bgdev.pl, kernel@collabora.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net v2 0/2] net: ethernet: mtk-star-emac: fix several issues on rx/tx poll
Date: Sat, 26 Apr 2025 02:20:32 +0000 [thread overview]
Message-ID: <174563403253.3902866.2022861799721968649.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250424-mtk_star_emac-fix-spinlock-recursion-issue-v2-0-f3fde2e529d8@collabora.com>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 24 Apr 2025 10:38:47 +0200 you wrote:
> This patchset fixes two issues with the mtk-star-emac driver.
>
> The first patch fixes spin lock recursion issues I've observed on the
> Mediatek Genio 350-EVK board using this driver when the Ethernet
> functionality is enabled on the board (requires a correct jumper and
> DIP switch configuration, as well as enabling the device in the
> devicetree).
> The issues can be easily reproduced with apt install or ssh commands
> especially and with the CONFIG_DEBUG_SPINLOCK parameter, when
> one occurs, there is backtrace similar to this:
> ```
> BUG: spinlock recursion on CPU#0, swapper/0/0
> lock: 0xffff00000db9cf20, .magic: dead4ead, .owner: swapper/0/0,
> .owner_cpu: 0
> CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted
> 6.15.0-rc2-next-20250417-00001-gf6a27738686c-dirty #28 PREEMPT
> Hardware name: MediaTek MT8365 Open Platform EVK (DT)
> Call trace:
> show_stack+0x18/0x24 (C)
> dump_stack_lvl+0x60/0x80
> dump_stack+0x18/0x24
> spin_dump+0x78/0x88
> do_raw_spin_lock+0x11c/0x120
> _raw_spin_lock+0x20/0x2c
> mtk_star_handle_irq+0xc0/0x22c [mtk_star_emac]
> __handle_irq_event_percpu+0x48/0x140
> handle_irq_event+0x4c/0xb0
> handle_fasteoi_irq+0xa0/0x1bc
> handle_irq_desc+0x34/0x58
> generic_handle_domain_irq+0x1c/0x28
> gic_handle_irq+0x4c/0x120
> do_interrupt_handler+0x50/0x84
> el1_interrupt+0x34/0x68
> el1h_64_irq_handler+0x18/0x24
> el1h_64_irq+0x6c/0x70
> regmap_mmio_read32le+0xc/0x20 (P)
> _regmap_bus_reg_read+0x6c/0xac
> _regmap_read+0x60/0xdc
> regmap_read+0x4c/0x80
> mtk_star_rx_poll+0x2f4/0x39c [mtk_star_emac]
> __napi_poll+0x38/0x188
> net_rx_action+0x164/0x2c0
> handle_softirqs+0x100/0x244
> __do_softirq+0x14/0x20
> ____do_softirq+0x10/0x20
> call_on_irq_stack+0x24/0x64
> do_softirq_own_stack+0x1c/0x40
> __irq_exit_rcu+0xd4/0x10c
> irq_exit_rcu+0x10/0x1c
> el1_interrupt+0x38/0x68
> el1h_64_irq_handler+0x18/0x24
> el1h_64_irq+0x6c/0x70
> cpuidle_enter_state+0xac/0x320 (P)
> cpuidle_enter+0x38/0x50
> do_idle+0x1e4/0x260
> cpu_startup_entry+0x34/0x3c
> rest_init+0xdc/0xe0
> console_on_rootfs+0x0/0x6c
> __primary_switched+0x88/0x90
> ```
>
> [...]
Here is the summary with links:
- [net,v2,1/2] net: ethernet: mtk-star-emac: fix spinlock recursion issues on rx/tx poll
https://git.kernel.org/netdev/net/c/6fe086601448
- [net,v2,2/2] net: ethernet: mtk-star-emac: rearm interrupts in rx_poll only when advised
https://git.kernel.org/netdev/net/c/e54b4db35e20
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-04-26 2:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 8:38 [PATCH net v2 0/2] net: ethernet: mtk-star-emac: fix several issues on rx/tx poll Louis-Alexis Eyraud
2025-04-24 8:38 ` [PATCH net v2 1/2] net: ethernet: mtk-star-emac: fix spinlock recursion " Louis-Alexis Eyraud
2025-04-24 9:00 ` Maxime Chevallier
2025-04-24 9:30 ` Bartosz Golaszewski
2025-04-24 8:38 ` [PATCH net v2 2/2] net: ethernet: mtk-star-emac: rearm interrupts in rx_poll only when advised Louis-Alexis Eyraud
2025-04-24 9:16 ` Maxime Chevallier
2025-04-26 2:13 ` Jakub Kicinski
2025-04-24 9:31 ` Bartosz Golaszewski
2025-04-26 2:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174563403253.3902866.2022861799721968649.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=biao.huang@mediatek.com \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@collabora.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=ot_yinghua.pan@mediatek.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.