From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Compile error (starfire ethernet) on 2.5.25 for crc32_le
Date: Wed, 10 Jul 2002 17:06:14 -0700 [thread overview]
Message-ID: <174620000.1026345974@flay> (raw)
In-Reply-To: <3D2CC764.6080002@mandrakesoft.com>
>> drivers/built-in.o: In function `set_rx_mode':
>> drivers/built-in.o(.text+0x2138c): undefined reference to `crc32_le'
>> make: *** [vmlinux] Error 1
>>
>> starfire.c calls ether_crc_le which is defined in include/linux/crc32.h as
>> # define ether_crc_le(length, data) crc32_le(~0, data, length)
>>
>> crc32_le is defined in lib/crc32.c .... which is only compiled if CONFIG_CRC32
>> is set ... setting this fixes the problem ... shouldn't drivers that need this turn it
>> on automatically somehow?
>
> They do already. drivers/net/Makefile.lib. The culprit is a typo. Wanna submit
> the obvious patch that does s/CONFIG_STARFIRE/CONFIG_ADAPTEC_STARFIRE/
> in dr/ne/Makefile.lib?
Done. Tested. Works. Thankyou!
Could you forward to Linus so it looks blessed?
Thanks,
M.
--- virgin-2.5.25/drivers/net/Makefile.lib Fri Jul 5 16:42:33 2002
+++ linux-2.5.25-starfire/drivers/net/Makefile.lib Wed Jul 10 16:55:07 2002
@@ -25,7 +25,7 @@
obj-$(CONFIG_PCNET32) += crc32.o
obj-$(CONFIG_SIS900) += crc32.o
obj-$(CONFIG_SMC9194) += crc32.o
-obj-$(CONFIG_STARFIRE) += crc32.o
+obj-$(CONFIG_ADAPTEC_STARFIRE) += crc32.o
obj-$(CONFIG_SUNBMAC) += crc32.o
obj-$(CONFIG_SUNDANCE) += crc32.o
obj-$(CONFIG_SUNGEM) += crc32.o
prev parent reply other threads:[~2002-07-11 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-10 23:21 Compile error (starfire ethernet) on 2.5.25 for crc32_le Martin J. Bligh
2002-07-10 23:46 ` Jeff Garzik
2002-07-11 0:06 ` Martin J. Bligh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174620000.1026345974@flay \
--to=martin.bligh@us.ibm.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.