Re: [Qemu-devel] blockdev-mirror , how to replace old nodename by new nodename ?

[Alexandre DERUMIER <aderumier@odiso.com>]

Ok thanks.

I'll retry without replaces, but I'm pretty sure It was not working too.


Also, I notice something strange,

when I define the job-id (which is mandatory), it's replace the device option.
(If I set a random job-id name, the mirroring is not working because it don't find the device).


----- Mail original -----
De: "Fam Zheng" <famz@redhat.com>
À: "aderumier" <aderumier@odiso.com>
Cc: "qemu-devel" <qemu-devel@nongnu.org>
Envoyé: Mercredi 19 Avril 2017 11:02:36
Objet: Re: [Qemu-devel] blockdev-mirror , how to replace old nodename by new nodename ?

On Wed, 04/19 09:08, Alexandre DERUMIER wrote: 
> Hi, 
> 
> I'm trying to implement blockdev-mirror, to replace drive-mirror as we can pass more options with blockdev-mirror. 
> 
> 
> I would like to mirror an attached blockdev to a new blockdev, then switch at the end of block-job-complete, like for drive-mirror. 
> 
> 
> qemu command line (vm-138-disk-1.qcow2 filename on "drive-virtio0" nodename: 
> 
> -blockdev {"node-name":"drive-virtio0","cache":{"direct":true},"driver":"qcow2","file":{"filename":"/var/lib/vz/images/138/vm-138-disk-1.qcow2","aio":"threads","driver":"file"}} 
> -device virtio-blk-pci,drive=drive-virtio0,id=virtio0,bus=pci.0,addr=0xa,write-cache=on 
> 
> 
> add a new blockdev with blockdev-add: (a file vm-138-disk-2.raw has been created before, I assign it to a "tempmirror" nodename) 
> 
> 
> {"arguments":{"driver":"raw","cache":{"direct":true},"node-name":"tempmirror","file":{"driver":"file","aio":"threads","filename":"/var/lib/vz/images/138/vm-138-disk-2.raw"}},"execute":"blockdev-add"} 
> 
> 
> blockdev-mirror: 
> 
> {"arguments":{"job-id":"drive-virtio0","target":"tempmirror","sync":"full","replaces":"drive-virtio0","device":"drive-virtio0"},"execute":"blockdev-mirror"} 
> 
> (I have try with or without replaces option) 
> 
> then query-name-block-nodes, show vm-138-disk-2.raw file on tempmirror "node-name", and vm-138-disk1.qcow2 on "drive-virtio0" node-name 
> 
> 
> I expected that both was switched, like for drive-mirror. 

The replace/switch happens when you do block-job-complete. 

And I think in your use case "replaces" is not needed. That one is for replacing 
a node under quorum 

Fam