From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 08/24] drm/omap: Separate the dssdevs array setup from the connect function Date: Tue, 27 Feb 2018 15:23:27 +0200 Message-ID: <17482301.TLKzWrlMzn@avalon> References: <1518428694-18018-1-git-send-email-tomi.valkeinen@ti.com> <1518428694-18018-9-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD71E6E67C for ; Tue, 27 Feb 2018 13:22:39 +0000 (UTC) In-Reply-To: <1518428694-18018-9-git-send-email-tomi.valkeinen@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: Peter Ujfalusi , Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5LCAxMiBGZWJydWFy eSAyMDE4IDExOjQ0OjM4IEVFVCBUb21pIFZhbGtlaW5lbiB3cm90ZToKPiBGcm9tOiBQZXRlciBV amZhbHVzaSA8cGV0ZXIudWpmYWx1c2lAdGkuY29tPgo+IAo+IEluIG9yZGVyIHRvIGVhc2UgdXAg b24gdGhlIGxvZ2ljLAoKSSBoYXZlIHNvbWUgZG91YnRzIGFib3V0IHRoaXMgOi0pIEkgZmluZCB0 aGUgbG9naWMgYm90aCBsYXJnZXIgKDQwIGluc2VydGlvbnMsIAoxNCBkZWxldGlvbnMpIGFuZCBt b3JlIGNvbXBsZXguCgo+IGJyZWFrIHRoZSBjdXJyZW50IGNvZGUgdG8gZ2F0aGVyIHRoZSBkc3Nk ZXZzOgo+IAo+IGZpcnN0IGdldCBhbGwgYXZhaWxhYmxlIGRzc2RldnMsIHRoZW4gY2FsbCBjb25u ZWN0IG9uIGVhY2ggZHNzZGV2LiBBcyB0aGUKPiBsYXN0IHN0ZXAgcmVtb3ZlIHRoZSBkc3NkZXZz IHdoaWNoIGZhaWxlZCB0byBjb25uZWN0IGZyb20gdGhlIGF2YWlsYWJsZQo+IGRzc2RldiBsaXN0 Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBldGVyIFVqZmFsdXNpIDxwZXRlci51amZhbHVzaUB0aS5j b20+Cj4gU2lnbmVkLW9mZi1ieTogVG9taSBWYWxrZWluZW4gPHRvbWkudmFsa2VpbmVuQHRpLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYyB8IDU0ICsrKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2Vy dGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vb21hcGRybS9vbWFwX2Rydi5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Ry di5jIGluZGV4IDg2OWE4YWI2YWE0ZS4uYjUwNjFmYzcyNDFhCj4gMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9v bWFwZHJtL29tYXBfZHJ2LmMKPiBAQCAtMTY1LDM0ICsxNjUsNjAgQEAgc3RhdGljIHZvaWQgb21h cF9kaXNjb25uZWN0X2Rzc2RldnMoc3RydWN0IGRybV9kZXZpY2UKPiAqZGRldikgcHJpdi0+bnVt X2Rzc2RldnMgPSAwOwo+ICB9Cj4gCj4gLXN0YXRpYyBpbnQgb21hcF9jb25uZWN0X2Rzc2RldnMo c3RydWN0IGRybV9kZXZpY2UgKmRkZXYpCj4gK3N0YXRpYyB2b2lkIG9tYXBfY29sbGVjdF9kc3Nk ZXZzKHN0cnVjdCBkcm1fZGV2aWNlICpkZGV2KQo+ICB7Cj4gIAlzdHJ1Y3Qgb21hcF9kcm1fcHJp dmF0ZSAqcHJpdiA9IGRkZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0IG9tYXBfZHNzX2Rldmlj ZSAqZHNzZGV2ID0gTlVMTDsKPiAtCWludCByOwo+ICsKPiArCWZvcl9lYWNoX2Rzc19kZXYoZHNz ZGV2KSB7Cj4gKwkJb21hcF9kc3NfZ2V0X2RldmljZShkc3NkZXYpOwo+ICsJCXByaXYtPmRzc2Rl dnNbcHJpdi0+bnVtX2Rzc2RldnMrK10gPSBkc3NkZXY7Cj4gKwkJaWYgKHByaXYtPm51bV9kc3Nk ZXZzID09IEFSUkFZX1NJWkUocHJpdi0+ZHNzZGV2cykpIHsKPiArCQkJLyogVG8gYmFsYW5jZSB0 aGUgJ2Zvcl9lYWNoX2Rzc19kZXYnIGxvb3AgKi8KPiArCQkJb21hcF9kc3NfcHV0X2RldmljZShk c3NkZXYpOwo+ICsJCQlicmVhazsKPiArCQl9Cj4gKwl9Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQg b21hcF9jb25uZWN0X2Rzc2RldnMoc3RydWN0IGRybV9kZXZpY2UgKmRkZXYpCj4gK3sKPiArCXN0 cnVjdCBvbWFwX2RybV9wcml2YXRlICpwcml2ID0gZGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwl1MzIg d29ya2luZyA9IDA7Cj4gKwlpbnQgciwgaSwgajsKPiAKPiAgCWlmICghb21hcGRzc19zdGFja19p c19yZWFkeSgpKQo+ICAJCXJldHVybiAtRVBST0JFX0RFRkVSOwo+IAo+IC0JZm9yX2VhY2hfZHNz X2Rldihkc3NkZXYpIHsKPiArCW9tYXBfY29sbGVjdF9kc3NkZXZzKGRkZXYpOwo+ICsKPiArCWZv ciAoaSA9IDA7IGkgPCBwcml2LT5udW1fZHNzZGV2czsgaSsrKSB7Cj4gKwkJc3RydWN0IG9tYXBf ZHNzX2RldmljZSAqZHNzZGV2ID0gcHJpdi0+ZHNzZGV2c1tpXTsKPiArCj4gIAkJciA9IGRzc2Rl di0+ZHJpdmVyLT5jb25uZWN0KGRzc2Rldik7Cj4gLQkJaWYgKHIgPT0gLUVQUk9CRV9ERUZFUikg ewo+IC0JCQlvbWFwX2Rzc19wdXRfZGV2aWNlKGRzc2Rldik7Cj4gKwkJaWYgKHIgPT0gLUVQUk9C RV9ERUZFUikKPiAgCQkJZ290byBjbGVhbnVwOwo+IC0JCX0gZWxzZSBpZiAocikgewo+ICsJCWVs c2UgaWYgKHIpCj4gIAkJCWRldl93YXJuKGRzc2Rldi0+ZGV2LCAiY291bGQgbm90IGNvbm5lY3Qg ZGlzcGxheTogJXNcbiIsCj4gLQkJCQlkc3NkZXYtPm5hbWUpOwo+ICsJCQkJIGRzc2Rldi0+bmFt ZSk7Cj4gKwkJZWxzZQo+ICsJCQl3b3JraW5nIHw9IEJJVChpKTsKPiArCX0KPiArCj4gKwkvKiBS ZW1vdmUgdGhlIGRzc2RldnMgaWYgdGhlaXIgY29ubmVjdCBmYWlsZWQgKi8KPiArCWogPSAwOwo+ ICsJZm9yIChpID0gMDsgaSA8IHByaXYtPm51bV9kc3NkZXZzOyBpKyspIHsKPiArCQlpZiAod29y a2luZyAmIEJJVChpKSkgewo+ICsJCQlpZiAoaiAhPSBpKQo+ICsJCQkJcHJpdi0+ZHNzZGV2c1tq XSA9IHByaXYtPmRzc2RldnNbaV07Cj4gKwkJCWorKzsKPiAgCQl9IGVsc2Ugewo+IC0JCQlvbWFw X2Rzc19nZXRfZGV2aWNlKGRzc2Rldik7Cj4gLQkJCXByaXYtPmRzc2RldnNbcHJpdi0+bnVtX2Rz c2RldnMrK10gPSBkc3NkZXY7Cj4gLQkJCWlmIChwcml2LT5udW1fZHNzZGV2cyA9PSBBUlJBWV9T SVpFKHByaXYtPmRzc2RldnMpKSB7Cj4gLQkJCQkvKiBUbyBiYWxhbmNlIHRoZSAnZm9yX2VhY2hf ZHNzX2RldicgbG9vcCAqLwo+IC0JCQkJb21hcF9kc3NfcHV0X2RldmljZShkc3NkZXYpOwo+IC0J CQkJYnJlYWs7Cj4gLQkJCX0KPiArCQkJb21hcF9kc3NfcHV0X2RldmljZShwcml2LT5kc3NkZXZz W2ldKTsKPiAgCQl9Cj4gIAl9Cj4gCj4gKwlwcml2LT5udW1fZHNzZGV2cyA9IGo7Cj4gKwo+ICAJ cmV0dXJuIDA7Cj4gCj4gIGNsZWFudXA6CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=