From: patchwork-bot+netdevbpf@kernel.org
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bpf@vger.kernel.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, ast@kernel.org,
daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org,
hawk@kernel.org, john.fastabend@gmail.com
Subject: Re: [PATCH] xdp: Remove unused events xdp_redirect_map and xdp_redirect_map_err
Date: Fri, 13 Jun 2025 02:50:32 +0000 [thread overview]
Message-ID: <174978303251.199960.6452866597649393391.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250611155615.0c2cf61c@batman.local.home>
Hello:
This patch was applied to bpf/bpf-next.git (net)
by Alexei Starovoitov <ast@kernel.org>:
On Wed, 11 Jun 2025 15:56:15 -0400 you wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> Each TRACE_EVENT() defined can take up around 5K of text and meta data
> regardless if they are used or not. New code is being developed that will
> warn when a tracepoint is defined but not used.
>
> The trace events xdp_redirect_map and xdp_redirect_map_err are defined but
> not used, but there's also a comment that states these are kept around for
> backward compatibility. Which is interesting because since they are not
> used, any old BPF program that expects them to exist will get incorrect
> data (no data) when they use them. It's worse than not working, it's
> silently failing.
>
> [...]
Here is the summary with links:
- xdp: Remove unused events xdp_redirect_map and xdp_redirect_map_err
https://git.kernel.org/bpf/bpf-next/c/a9a5f41b04dd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-06-13 2:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 19:56 [PATCH] xdp: Remove unused events xdp_redirect_map and xdp_redirect_map_err Steven Rostedt
2025-06-12 10:30 ` Toke Høiland-Jørgensen
2025-06-12 10:54 ` Jesper Dangaard Brouer
2025-06-16 12:05 ` Jesper Dangaard Brouer
2025-06-16 12:42 ` Toke Høiland-Jørgensen
2025-06-13 2:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174978303251.199960.6452866597649393391.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.