From: "René Scharfe" <l.s.r@web.de>
To: Lidong Yan via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Lidong Yan <502024330056@smail.nju.edu.cn>
Subject: Re: [PATCH] REFTABLE_REALLOC_ARRAY: fix potential memory leak if realloc failed
Date: Thu, 8 May 2025 23:42:37 +0200 [thread overview]
Message-ID: <174cb568-e2bd-41e0-b090-eadd919d1ddd@web.de> (raw)
In-Reply-To: <pull.1955.git.git.1746711583166.gitgitgadget@gmail.com>
Am 08.05.25 um 15:39 schrieb Lidong Yan via GitGitGadget:
> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>
> REFTABLE_REALLOC_ARRAY doesn't free origin pointer when reftable_realloc
> failed. This leak can be fixed by add a free(x) before set x to NULL.
Hmm, this macro is unused. Perhaps remove it?
René
next prev parent reply other threads:[~2025-05-08 21:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 13:39 [PATCH] REFTABLE_REALLOC_ARRAY: fix potential memory leak if realloc failed Lidong Yan via GitGitGadget
2025-05-08 21:42 ` René Scharfe [this message]
2025-05-09 1:54 ` lidongyan
2025-05-09 3:43 ` Junio C Hamano
2025-05-09 2:04 ` [PATCH v2] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro Lidong Yan via GitGitGadget
2025-05-09 6:51 ` Patrick Steinhardt
2025-05-09 7:38 ` lidongyan
2025-05-09 7:44 ` [PATCH v3] " Lidong Yan via GitGitGadget
2025-05-09 8:23 ` Patrick Steinhardt
2025-05-09 14:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174cb568-e2bd-41e0-b090-eadd919d1ddd@web.de \
--to=l.s.r@web.de \
--cc=502024330056@smail.nju.edu.cn \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.