All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Alex Hung <alex.hung@amd.com>, <igt-dev@lists.freedesktop.org>
Cc: Alex Hung <alex.hung@amd.com>
Subject: Re: [PATCH] README.md: Update oneliner build command
Date: Thu, 19 Jun 2025 09:43:46 -0300	[thread overview]
Message-ID: <175033702686.1504.17422631719024862630@intel.com> (raw)
In-Reply-To: <20250618230257.1721932-1-alex.hung@amd.com>

Quoting Alex Hung (2025-06-18 20:02:57-03:00)
>This fixes the following warning:
>
>WARNING: Running the setup command as `meson [options]` instead of
>`meson setup [options]` is ambiguous and deprecated.
>
>Signed-off-by: Alex Hung <alex.hung@amd.com>

Looks good, so

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

That said, perhaps we could take this opportunity to fix other
occurrences as well? There is another one in README.md and others in
.gitlab-ci.yml and meson.sh.

Quickly doing a git log on meson's manpage file, the setup command is
available since at least 2017[1]. So perhaps updating .gitlab-ci.yml to
use the "setup" should be fine?

[1] https://github.com/mesonbuild/meson/commit/d82c7e3c23ce6f3b0b68aea034c3f9d4d7b68935

--
Gustavo Sousa

>---
> README.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/README.md b/README.md
>index 9cef60d88..ed6647726 100644
>--- a/README.md
>+++ b/README.md
>@@ -37,7 +37,7 @@ Building
> 
> Oneliner to get started:
> 
>-    $ meson build && ninja -C build
>+    $ meson setup build && ninja -C build
> 
> Note that meson insist on separate build directories from the source tree.
> 
>-- 
>2.43.0
>

  parent reply	other threads:[~2025-06-19 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18 23:02 [PATCH] README.md: Update oneliner build command Alex Hung
2025-06-19  1:42 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-06-19  7:08 ` ✓ i915.CI.BAT: " Patchwork
2025-06-19 12:43 ` Gustavo Sousa [this message]
2025-06-23  9:59   ` [PATCH] " Kamil Konieczny
2025-06-19 14:25 ` ✗ Xe.CI.Full: failure for " Patchwork
2025-06-23 10:00   ` Kamil Konieczny
2025-06-19 14:54 ` ✗ i915.CI.Full: " Patchwork
2025-06-23 10:01   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175033702686.1504.17422631719024862630@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=alex.hung@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.