All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Mahesh Bandewar <mahesh@bandewar.net>
Cc: Andy Gospodarek <andy@greyhouse.net>,
	Veaceslav Falico <vfalico@gmail.com>,
	Nikolay Aleksandrov <nikolay@redhat.com>,
	David Miller <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	netdev <netdev@vger.kernel.org>,
	Mahesh Bandewar <maheshb@google.com>
Subject: Re: [PATCH next 0/5] bonding: winter cleanup
Date: Wed, 08 Mar 2017 15:24:06 -0800	[thread overview]
Message-ID: <17528.1489015446@famine> (raw)
In-Reply-To: <20170308185545.22864-1-mahesh@bandewar.net>

Mahesh Bandewar <mahesh@bandewar.net> wrote:

>From: Mahesh Bandewar <maheshb@google.com>
>
>Few cleanup patches that I have accumulated over some time now.
>
>(a) First two patches are basically to move the work-queue initialization
>    from every ndo_open / bond_open operation to once at the beginning while
>    port creation. Work-queue initialization is an unnecessary operation
>    for every 'ifup' operation. However we have some mode-specific work-queues
>    and mode can change anytime after port creation. So the second patch is
>    to ensure the correct work-handler is called based on the mode.
>
>(b) Third patch is simple and straightforward that removes hard-coded value
>    that was added into the initial commit and replaces it with the default
>    value configured.
>
>(c) The final patch in the series removes the unimplemented "port-moved" state
>    from the LACP state machine. This state is defined but never set so
>    removing from the state machine logic makes code little cleaner.
>
>(d) Reduce scope of some global variables to local.

	For all patches in the series:

Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical.com>

>Note: None of these patches are making any functional changes.
>
>Mahesh Bandewar (5):
>  bonding: restructure arp-monitor
>  bonding: initialize work-queues during creation of bond
>  bonding: remove hardcoded value
>  bonding: remove "port-moved" state that was never implemented
>  bonding: reduce scope of some global variables
>
> drivers/net/bonding/bond_3ad.c  | 11 +++------
> drivers/net/bonding/bond_main.c | 53 ++++++++++++++++++++++++++---------------
> 2 files changed, 37 insertions(+), 27 deletions(-)
>
>-- 
>2.12.0.246.ga2ecc84866-goog

---
	-Jay Vosburgh, jay.vosburgh@canonical.com

  reply	other threads:[~2017-03-09  0:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 18:55 [PATCH next 0/5] bonding: winter cleanup Mahesh Bandewar
2017-03-08 23:24 ` Jay Vosburgh [this message]
2017-03-10  1:33 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17528.1489015446@famine \
    --to=jay.vosburgh@canonical.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=mahesh@bandewar.net \
    --cc=maheshb@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@redhat.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.