From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.4.y] comedi: Fix some signed shift left operations
Date: Fri, 25 Jul 2025 19:26:22 -0400 [thread overview]
Message-ID: <1753464894-7fb32196@stable.kernel.org> (raw)
In-Reply-To: <20250724182218.292203-2-abbotti@mev.co.uk>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: ab705c8c35e18652abc6239c07cf3441f03e2cda
Status in newer kernel trees:
6.15.y | Not found
6.12.y | Not found
6.6.y | Not found
6.1.y | Not found
5.15.y | Not found
5.10.y | Not found
Note: The patch differs from the upstream commit:
---
1: ab705c8c35e1 ! 1: e6c1da157d18 comedi: Fix some signed shift left operations
@@ Metadata
## Commit message ##
comedi: Fix some signed shift left operations
+ [ Upstream commit ab705c8c35e18652abc6239c07cf3441f03e2cda ]
+
Correct some left shifts of the signed integer constant 1 by some
unsigned number less than 32. Change the constant to 1U to avoid
shifting a 1 into the sign bit.
@@ Commit message
Link: https://lore.kernel.org/r/20250707121555.65424-1-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
- ## drivers/comedi/drivers.c ##
-@@ drivers/comedi/drivers.c: int comedi_dio_insn_config(struct comedi_device *dev,
+ ## drivers/staging/comedi/drivers.c ##
+@@ drivers/staging/comedi/drivers.c: int comedi_dio_insn_config(struct comedi_device *dev,
unsigned int *data,
unsigned int mask)
{
@@ drivers/comedi/drivers.c: int comedi_dio_insn_config(struct comedi_device *dev,
switch (data[0]) {
case INSN_CONFIG_DIO_INPUT:
-@@ drivers/comedi/drivers.c: EXPORT_SYMBOL_GPL(comedi_dio_insn_config);
+@@ drivers/staging/comedi/drivers.c: EXPORT_SYMBOL_GPL(comedi_dio_insn_config);
unsigned int comedi_dio_update_state(struct comedi_subdevice *s,
unsigned int *data)
{
@@ drivers/comedi/drivers.c: EXPORT_SYMBOL_GPL(comedi_dio_insn_config);
: 0xffffffff;
unsigned int mask = data[0] & chanmask;
unsigned int bits = data[1];
-@@ drivers/comedi/drivers.c: static int insn_rw_emulate_bits(struct comedi_device *dev,
+@@ drivers/staging/comedi/drivers.c: static int insn_rw_emulate_bits(struct comedi_device *dev,
if (insn->insn == INSN_WRITE) {
if (!(s->subdev_flags & SDF_WRITABLE))
return -EINVAL;
@@ drivers/comedi/drivers.c: static int insn_rw_emulate_bits(struct comedi_device *
}
ret = s->insn_bits(dev, s, &_insn, _data);
-@@ drivers/comedi/drivers.c: static int __comedi_device_postconfig(struct comedi_device *dev)
+@@ drivers/staging/comedi/drivers.c: static int __comedi_device_postconfig(struct comedi_device *dev)
if (s->type == COMEDI_SUBD_DO) {
if (s->n_chan < 32)
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| origin/linux-5.4.y | Success | Success |
prev parent reply other threads:[~2025-07-25 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 18:22 [PATCH 5.4.y] comedi: Fix some signed shift left operations Ian Abbott
2025-07-25 23:26 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1753464894-7fb32196@stable.kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.