All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Subject: Re: [PATCH] v4l2-fh: Add forward declaration for struct file
Date: Thu, 03 Oct 2013 23:54:02 +0200	[thread overview]
Message-ID: <1753722.grHNBxjFLq@avalon> (raw)
In-Reply-To: <1380836936-20914-1-git-send-email-laurent.pinchart@ideasonboard.com>

On Thursday 03 October 2013 23:48:56 Laurent Pinchart wrote:
> Pointers to struct file are used as function arguments, but the
> structure isn't declared. Add a forward declaration.

Scratch this, I've sent the patch too soon. struct file is dereferenced in 
v4l2-fh.h, it does need to be properly defined. I'll send the correct patch. 
Sorry for the noise.

> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  include/media/v4l2-fh.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/media/v4l2-fh.h b/include/media/v4l2-fh.h
> index a62ee18..76aeec7 100644
> --- a/include/media/v4l2-fh.h
> +++ b/include/media/v4l2-fh.h
> @@ -28,6 +28,7 @@
> 
>  #include <linux/list.h>
> 
> +struct file;
>  struct video_device;
>  struct v4l2_ctrl_handler;
-- 
Regards,

Laurent Pinchart


      reply	other threads:[~2013-10-03 21:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 21:48 [PATCH] v4l2-fh: Add forward declaration for struct file Laurent Pinchart
2013-10-03 21:54 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1753722.grHNBxjFLq@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.