From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/omap: fix crash if there's no video PLL Date: Thu, 05 Apr 2018 11:05:42 +0300 Message-ID: <1753911.LsArlMeJuA@avalon> References: <20180405065537.29818-1-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0ECE6E6CC for ; Thu, 5 Apr 2018 08:05:32 +0000 (UTC) In-Reply-To: <20180405065537.29818-1-tomi.valkeinen@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: Keerthy , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKCk9uIFRodXJzZGF5LCA1IEFwcmlsIDIwMTggMDk6NTU6MzcgRUVTVCBUb21pIFZh bGtlaW5lbiB3cm90ZToKPiBDb21taXQgOGE3ZWRhNzY4NjY3NWI3M2Q3NGMyMmMwZDViODMwNTlm OWQ3ODNmNiAoImRybTogb21hcGRybTogZGlzcGM6Cj4gUGFzcyBESVNQQyBwb2ludGVyIHRvIHJl bWFpbmluZyBkaXNwYyBBUEkgZnVuY3Rpb25zIikgbWFkZSBkcGkuYyB1c2UKPiBjdHgtPnBsbCBl dmVuIHdoZW4gdGhlcmUncyBubyBQTEwsIGNhdXNpbmcgYSBjcmFzaCBhdCBtb2Rlc2V0IG9uIEFN NAo+IEVWTSwgYW5kIHByZXN1bWFibHkgYWxsIE9NQVAyLzMgYm9hcmRzLgo+IAo+IEZpeCB0aGlz IGJ5IGhhdmluZyBzdHJ1Y3QgZHBpX2RhdGEgcG9pbnRlciBpbiB0aGUgY3R4IGluc3RlYWQsIGdp dmluZwo+IGFjY2VzcyB0byBkaXNwYyB3aXRob3V0IGdvaW5nIHRocm91Z2ggdGhlIHBsbC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBUb21pIFZhbGtlaW5lbiA8dG9taS52YWxrZWluZW5AdGkuY29tPgo+ IFJlcG9ydGVkLWJ5OiBLZWVydGh5IDxqLWtlZXJ0aHlAdGkuY29tPgo+IENjOiBMYXVyZW50IFBp bmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+CgpPb3BzLCBzb3JyeSBh Ym91dCB0aGlzIDotLwoKWW91IHNob3VsZCBhZGQgYQoKRml4ZXM6IDhhN2VkYTc2ODY2NyAoImRy bTogb21hcGRybTogZGlzcGM6IFBhc3MgRElTUEMgcG9pbnRlciB0byByZW1haW5pbmcgCmRpc3Bj IEFQSSBmdW5jdGlvbnMiKQoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQu cGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFw ZHJtL2Rzcy9kcGkuYyB8IDE1ICsrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOCBp bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vb21hcGRybS9kc3MvZHBpLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL2Rzcy9k cGkuYyBpbmRleCBmYjFjMjdmNjllM2EuLjNkNjYyZTY4MDVlYiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vb21hcGRybS9kc3MvZHBpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vb21h cGRybS9kc3MvZHBpLmMKPiBAQCAtMTQyLDcgKzE0Miw3IEBAIHN0YXRpYyBlbnVtIGRzc19jbGtf c291cmNlIGRwaV9nZXRfY2xrX3NyYyhzdHJ1Y3QKPiBkcGlfZGF0YSAqZHBpKSB9Cj4gCj4gIHN0 cnVjdCBkcGlfY2xrX2NhbGNfY3R4IHsKPiAtCXN0cnVjdCBkc3NfcGxsICpwbGw7Cj4gKwlzdHJ1 Y3QgZHBpX2RhdGEgKmRwaTsKPiAgCXVuc2lnbmVkIGludCBjbGtvdXRfaWR4Owo+IAo+ICAJLyog aW5wdXRzICovCj4gQEAgLTE5MSw3ICsxOTEsNyBAQCBzdGF0aWMgYm9vbCBkcGlfY2FsY19oc2Rp dl9jYihpbnQgbV9kaXNwYywgdW5zaWduZWQgbG9uZwo+IGRpc3BjLCBjdHgtPnBsbF9jaW5mby5t WFtjdHgtPmNsa291dF9pZHhdID0gbV9kaXNwYzsKPiAgCWN0eC0+cGxsX2NpbmZvLmNsa291dFtj dHgtPmNsa291dF9pZHhdID0gZGlzcGM7Cj4gCj4gLQlyZXR1cm4gZGlzcGNfZGl2X2NhbGMoY3R4 LT5wbGwtPmRzcy0+ZGlzcGMsIGRpc3BjLAo+ICsJcmV0dXJuIGRpc3BjX2Rpdl9jYWxjKGN0eC0+ ZHBpLT5kc3MtPmRpc3BjLCBkaXNwYywKPiAgCQkJICAgICAgY3R4LT5wY2tfbWluLCBjdHgtPnBj a19tYXgsCj4gIAkJCSAgICAgIGRwaV9jYWxjX2Rpc3BjX2NiLCBjdHgpOwo+ICB9Cj4gQEAgLTIw OCw4ICsyMDgsOCBAQCBzdGF0aWMgYm9vbCBkcGlfY2FsY19wbGxfY2IoaW50IG4sIGludCBtLCB1 bnNpZ25lZCBsb25nCj4gZmludCwgY3R4LT5wbGxfY2luZm8uZmludCA9IGZpbnQ7Cj4gIAljdHgt PnBsbF9jaW5mby5jbGtkY28gPSBjbGtkY287Cj4gCj4gLQlyZXR1cm4gZHNzX3BsbF9oc2Rpdl9j YWxjX2EoY3R4LT5wbGwsIGNsa2RjbywKPiAtCQljdHgtPnBja19taW4sIGRzc19nZXRfbWF4X2Zj a19yYXRlKGN0eC0+cGxsLT5kc3MpLAo+ICsJcmV0dXJuIGRzc19wbGxfaHNkaXZfY2FsY19hKGN0 eC0+ZHBpLT5wbGwsIGNsa2RjbywKPiArCQljdHgtPnBja19taW4sIGRzc19nZXRfbWF4X2Zja19y YXRlKGN0eC0+ZHBpLT5kc3MpLAo+ICAJCWRwaV9jYWxjX2hzZGl2X2NiLCBjdHgpOwo+ICB9Cj4g Cj4gQEAgLTIxOSw3ICsyMTksNyBAQCBzdGF0aWMgYm9vbCBkcGlfY2FsY19kc3NfY2IodW5zaWdu ZWQgbG9uZyBmY2ssIHZvaWQKPiAqZGF0YSkKPiAKPiAgCWN0eC0+ZmNrID0gZmNrOwo+IAo+IC0J cmV0dXJuIGRpc3BjX2Rpdl9jYWxjKGN0eC0+cGxsLT5kc3MtPmRpc3BjLCBmY2ssCj4gKwlyZXR1 cm4gZGlzcGNfZGl2X2NhbGMoY3R4LT5kcGktPmRzcy0+ZGlzcGMsIGZjaywKPiAgCQkJICAgICAg Y3R4LT5wY2tfbWluLCBjdHgtPnBja19tYXgsCj4gIAkJCSAgICAgIGRwaV9jYWxjX2Rpc3BjX2Ni LCBjdHgpOwo+ICB9Cj4gQEAgLTIzMCw3ICsyMzAsNyBAQCBzdGF0aWMgYm9vbCBkcGlfcGxsX2Ns a19jYWxjKHN0cnVjdCBkcGlfZGF0YSAqZHBpLAo+IHVuc2lnbmVkIGxvbmcgcGNrLCB1bnNpZ25l ZCBsb25nIGNsa2luOwo+IAo+ICAJbWVtc2V0KGN0eCwgMCwgc2l6ZW9mKCpjdHgpKTsKPiAtCWN0 eC0+cGxsID0gZHBpLT5wbGw7Cj4gKwljdHgtPmRwaSA9IGRwaTsKPiAgCWN0eC0+Y2xrb3V0X2lk eCA9IGRzc19wbGxfZ2V0X2Nsa291dF9pZHhfZm9yX3NyYyhkcGktPmNsa19zcmMpOwo+IAo+ICAJ Y2xraW4gPSBjbGtfZ2V0X3JhdGUoZHBpLT5wbGwtPmNsa2luKTsKPiBAQCAtMjQ0LDcgKzI0NCw3 IEBAIHN0YXRpYyBib29sIGRwaV9wbGxfY2xrX2NhbGMoc3RydWN0IGRwaV9kYXRhICpkcGksCj4g dW5zaWduZWQgbG9uZyBwY2ssIHBsbF9taW4gPSAwOwo+ICAJCXBsbF9tYXggPSAwOwo+IAo+IC0J CXJldHVybiBkc3NfcGxsX2NhbGNfYShjdHgtPnBsbCwgY2xraW4sCj4gKwkJcmV0dXJuIGRzc19w bGxfY2FsY19hKGN0eC0+ZHBpLT5wbGwsIGNsa2luLAo+ICAJCQkJcGxsX21pbiwgcGxsX21heCwK PiAgCQkJCWRwaV9jYWxjX3BsbF9jYiwgY3R4KTsKPiAgCX0gZWxzZSB7IC8qIERTU19QTExfVFlQ RV9CICovCj4gQEAgLTI3NSw2ICsyNzUsNyBAQCBzdGF0aWMgYm9vbCBkcGlfZHNzX2Nsa19jYWxj KHN0cnVjdCBkcGlfZGF0YSAqZHBpLAo+IHVuc2lnbmVkIGxvbmcgcGNrLCBib29sIG9rOwo+IAo+ ICAJCW1lbXNldChjdHgsIDAsIHNpemVvZigqY3R4KSk7Cj4gKwkJY3R4LT5kcGkgPSBkcGk7Cj4g IAkJaWYgKHBjayA+IDEwMDAgKiBpICogaSAqIGkpCj4gIAkJCWN0eC0+cGNrX21pbiA9IG1heChw Y2sgLSAxMDAwICogaSAqIGkgKiBpLCAwbHUpOwo+ICAJCWVsc2UKCi0tIApSZWdhcmRzLAoKTGF1 cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK