From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dhowells@redhat.com, Jens Axboe <axboe@kernel.dk>,
Al Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hillf Danton <hdanton@sina.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
Date: Mon, 13 Feb 2023 10:11:01 +0000 [thread overview]
Message-ID: <1753989.1676283061@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y+n0n2UE8BQa/OwW@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
> Also why doesn't this use init_sync_kiocb?
I'm not sure I want ki_flags.
> > if (in->f_flags & O_DIRECT)
> > return generic_file_direct_splice_read(in, ppos, pipe, len, flags);
> > + return generic_file_buffered_splice_read(in, ppos, pipe, len, flags);
>
> Btw, can we drop the verbose generic_file_ prefix here?
Probably. Note that at some point cifs, for example, running in "unbuffered"
mode might want to call [generic_file_]direct_splice_read() directly.
David
next prev parent reply other threads:[~2023-02-13 10:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 10:29 [PATCH v13 00/12] iov_iter: Improve page extraction (pin or just list) David Howells
2023-02-09 10:29 ` [PATCH v13 01/12] splice: Fix O_DIRECT file read splice to avoid reversion of ITER_PIPE David Howells
2023-02-09 14:53 ` Matthew Wilcox
2023-02-09 15:06 ` David Howells
2023-02-09 16:15 ` [PATCH v14 " David Howells
2023-02-13 8:22 ` Christoph Hellwig
2023-02-15 13:17 ` David Howells
2023-02-15 14:24 ` Christoph Hellwig
2023-02-15 15:56 ` David Howells
2023-02-15 13:42 ` [PATCH] splice: Clean up direct_splice_read() a bit David Howells
2023-02-15 13:47 ` David Howells
2023-02-09 10:29 ` [PATCH v13 02/12] mm: Pass info, not iter, into filemap_get_pages() and unstatic it David Howells
2023-02-13 8:22 ` Christoph Hellwig
2023-02-09 10:29 ` [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE David Howells
2023-02-13 8:28 ` Christoph Hellwig
2023-02-13 10:11 ` David Howells [this message]
2023-02-13 10:18 ` Christoph Hellwig
2023-02-13 11:15 ` David Howells
2023-02-13 14:44 ` Christoph Hellwig
2023-02-13 18:06 ` Guenter Roeck
2023-02-13 22:43 ` David Howells
2023-02-13 22:51 ` Guenter Roeck
2023-02-13 23:12 ` David Howells
2023-02-13 23:25 ` Guenter Roeck
2023-02-09 10:29 ` [PATCH v13 04/12] iov_iter: Kill ITER_PIPE David Howells
2023-02-13 8:28 ` Christoph Hellwig
2023-02-09 10:29 ` [PATCH v13 05/12] iov_iter: Define flags to qualify page extraction David Howells
2023-02-09 10:29 ` [PATCH v13 06/12] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-02-09 10:29 ` [PATCH v13 07/12] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-02-09 10:29 ` [PATCH v13 08/12] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-02-09 10:29 ` [PATCH v13 09/12] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-02-09 10:29 ` [PATCH v13 10/12] block: Add BIO_PAGE_PINNED and associated infrastructure David Howells
2023-02-09 10:29 ` [PATCH v13 11/12] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-02-09 10:29 ` [PATCH v13 12/12] block: convert bio_map_user_iov " David Howells
2023-02-10 22:31 ` [PATCH v13 00/12] iov_iter: Improve page extraction (pin or just list) Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1753989.1676283061@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.