All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Christoph Paasch <cpaasch@openai.com>
Cc: saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com,
	leon@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	amirv@mellanox.com, netdev@vger.kernel.org,
	linux-rdma@vger.kernel.org, gal@nvidia.com
Subject: Re: [PATCH net] net/mlx5: Correctly set gso_segs when LRO is used
Date: Fri, 01 Aug 2025 21:40:10 +0000	[thread overview]
Message-ID: <175408441027.4089984.2960748466316299557.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250729-mlx5_gso_segs-v1-1-b48c480c1c12@openai.com>

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 29 Jul 2025 11:34:00 -0700 you wrote:
> From: Christoph Paasch <cpaasch@openai.com>
> 
> When gso_segs is left at 0, a number of assumptions will end up being
> incorrect throughout the stack.
> 
> For example, in the GRO-path, we set NAPI_GRO_CB()->count to gso_segs.
> So, if a non-LRO'ed packet followed by an LRO'ed packet is being
> processed in GRO, the first one will have NAPI_GRO_CB()->count set to 1 and
> the next one to 0 (in dev_gro_receive()).
> Since commit 531d0d32de3e
> ("net/mlx5: Correctly set gso_size when LRO is used")
> these packets will get merged (as their gso_size now matches).
> So, we end up in gro_complete() with NAPI_GRO_CB()->count == 1 and thus
> don't call inet_gro_complete(). Meaning, checksum-validation in
> tcp_checksum_complete() will fail with a "hw csum failure".
> 
> [...]

Here is the summary with links:
  - [net] net/mlx5: Correctly set gso_segs when LRO is used
    https://git.kernel.org/netdev/net/c/77bf1c55b2ac

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2025-08-01 21:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 18:34 [PATCH net] net/mlx5: Correctly set gso_segs when LRO is used Christoph Paasch
2025-07-29 18:34 ` Christoph Paasch via B4 Relay
2025-07-30 11:06 ` Gal Pressman
2025-07-30 12:28   ` Eric Dumazet
2025-07-30 16:31     ` Christoph Paasch
2025-07-30 17:04       ` Willem de Bruijn
2025-08-01 21:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175408441027.4089984.2960748466316299557.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=amirv@mellanox.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=cpaasch@openai.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.