From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
alexanderduyck@fb.com
Subject: Re: [PATCH net] eth: fbnic: remove the debugging trick of super high page bias
Date: Tue, 05 Aug 2025 23:20:14 +0000 [thread overview]
Message-ID: <175443601438.2197607.222527424846735387.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250801170754.2439577-1-kuba@kernel.org>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 1 Aug 2025 10:07:54 -0700 you wrote:
> Alex added page bias of LONG_MAX, which is admittedly quite
> a clever way of catching overflows of the pp ref count.
> The page pool code was "optimized" to leave the ref at 1
> for freed pages so it can't catch basic bugs by itself any more.
> (Something we should probably address under DEBUG_NET...)
>
> Unfortunately for fbnic since commit f7dc3248dcfb ("skbuff: Optimization
> of SKB coalescing for page pool") core _may_ actually take two extra
> pp refcounts, if one of them is returned before driver gives up the bias
> the ret < 0 check in page_pool_unref_netmem() will trigger.
>
> [...]
Here is the summary with links:
- [net] eth: fbnic: remove the debugging trick of super high page bias
https://git.kernel.org/netdev/net/c/e407fceeaf1b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-08-05 23:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 17:07 [PATCH net] eth: fbnic: remove the debugging trick of super high page bias Jakub Kicinski
2025-08-05 23:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175443601438.2197607.222527424846735387.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.