From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:41571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728072AbeIUVBF (ORCPT ); Fri, 21 Sep 2018 17:01:05 -0400 From: David Howells In-Reply-To: <20180920151214.15484-7-mszeredi@redhat.com> References: <20180920151214.15484-7-mszeredi@redhat.com> <20180920151214.15484-1-mszeredi@redhat.com> To: Miklos Szeredi Cc: dhowells@redhat.com, Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] fsconfig: rename FSCONFIG_CMD_CREATE to FSCONFIG_CMD_OBTAIN MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17546.1537542706.1@warthog.procyon.org.uk> Date: Fri, 21 Sep 2018 16:11:46 +0100 Message-ID: <17547.1537542706@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Miklos Szeredi wrote: > The old name strongly implies that a new superblock will be created from > the fs_context. This is not true: filesystems are free to retuse an > existing superblock and return that (for good reason). Kind of like open(O_CREAT) only ever creates files, right;-) Actually, FSCONFIG_CMD_OPEN might be a better name. David