All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Qingfang Deng <dqfext@gmail.com>
Cc: mostrows@earthlink.net, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] pppoe: remove rwlock usage
Date: Fri, 29 Aug 2025 20:50:27 +0000	[thread overview]
Message-ID: <175650062774.2336923.18117158864204534101.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250828012018.15922-1-dqfext@gmail.com>

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 28 Aug 2025 09:20:16 +0800 you wrote:
> Like ppp_generic.c, convert the PPPoE socket hash table to use RCU for
> lookups and a spinlock for updates. This removes rwlock usage and allows
> lockless readers on the fast path.
> 
> - Mark hash table and list pointers as __rcu.
> - Use spin_lock() to protect writers.
> - Readers use rcu_dereference() under rcu_read_lock(). All known callers
>   of get_item() already hold the RCU read lock, so no additional locking
>   is needed.
> - get_item() now uses refcount_inc_not_zero() instead of sock_hold() to
>   safely take a reference. This prevents crashes if a socket is already
>   in the process of being freed (sk_refcnt == 0).
> - Set SOCK_RCU_FREE to defer socket freeing until after an RCU grace
>   period.
> - Move skb_queue_purge() into sk_destruct callback to ensure purge
>   happens after an RCU grace period.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/2] pppoe: remove rwlock usage
    https://git.kernel.org/netdev/net-next/c/72cdc67e7fa7
  - [net-next,v3,2/2] pppoe: drop sock reference counting on fast path
    https://git.kernel.org/netdev/net-next/c/4f54dff818d7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2025-08-29 20:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28  1:20 [PATCH net-next v3 1/2] pppoe: remove rwlock usage Qingfang Deng
2025-08-28  1:20 ` [PATCH net-next v3 2/2] pppoe: drop sock reference counting on fast path Qingfang Deng
2025-08-28  7:09   ` Eric Dumazet
2025-08-28  7:01 ` [PATCH net-next v3 1/2] pppoe: remove rwlock usage Eric Dumazet
2025-08-29 20:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175650062774.2336923.18117158864204534101.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mostrows@earthlink.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.