From: patchwork-bot+netdevbpf@kernel.org
To: Krister Johansen <kjlx@templeofstupid.com>
Cc: matttbe@kernel.org, martineau@kernel.org, geliang@kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, fw@strlen.de,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org, me@davidreaver.com
Subject: Re: [PATCH net v2] mptcp: sockopt: make sync_socket_options propagate SOCK_KEEPOPEN
Date: Wed, 10 Sep 2025 01:50:11 +0000 [thread overview]
Message-ID: <175746901150.871782.13982454785645572183.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <aL8dYfPZrwedCIh9@templeofstupid.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 8 Sep 2025 11:16:01 -0700 you wrote:
> Users reported a scenario where MPTCP connections that were configured
> with SO_KEEPALIVE prior to connect would fail to enable their keepalives
> if MTPCP fell back to TCP mode.
>
> After investigating, this affects keepalives for any connection where
> sync_socket_options is called on a socket that is in the closed or
> listening state. Joins are handled properly. For connects,
> sync_socket_options is called when the socket is still in the closed
> state. The tcp_set_keepalive() function does not act on sockets that
> are closed or listening, hence keepalive is not immediately enabled.
> Since the SO_KEEPOPEN flag is absent, it is not enabled later in the
> connect sequence via tcp_finish_connect. Setting the keepalive via
> sockopt after connect does work, but would not address any subsequently
> created flows.
>
> [...]
Here is the summary with links:
- [net,v2] mptcp: sockopt: make sync_socket_options propagate SOCK_KEEPOPEN
https://git.kernel.org/netdev/net/c/648de37416b3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-09-10 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 18:16 [PATCH net v2] mptcp: sockopt: make sync_socket_options propagate SOCK_KEEPOPEN Krister Johansen
2025-09-10 1:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175746901150.871782.13982454785645572183.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kjlx@templeofstupid.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=me@davidreaver.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.