From: patchwork-bot+netdevbpf@kernel.org
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: netdev@vger.kernel.org, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, vladbu@nvidia.com, dlinkin@nvidia.com
Subject: Re: [PATCH net] devlink rate: Remove unnecessary 'static' from a couple places
Date: Thu, 18 Sep 2025 15:00:20 +0000 [thread overview]
Message-ID: <175820762049.2450229.11267031301923458832.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250918101506.3671052-1-cratiu@nvidia.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 18 Sep 2025 13:15:06 +0300 you wrote:
> devlink_rate_node_get_by_name() and devlink_rate_nodes_destroy() have a
> couple of unnecessary static variables for iterating over devlink rates.
>
> This could lead to races/corruption/unhappiness if two concurrent
> operations execute the same function.
>
> Remove 'static' from both. It's amazing this was missed for 4+ years.
> While at it, I confirmed there are no more examples of this mistake in
> net/ with 1, 2 or 3 levels of indentation.
>
> [...]
Here is the summary with links:
- [net] devlink rate: Remove unnecessary 'static' from a couple places
https://git.kernel.org/netdev/net/c/3191df0a4882
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-09-18 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 10:15 [PATCH net] devlink rate: Remove unnecessary 'static' from a couple places Cosmin Ratiu
2025-09-18 15:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175820762049.2450229.11267031301923458832.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dlinkin@nvidia.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.