All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix v7M build for !CONFIG_PRINTK
Date: Mon, 12 Jan 2015 09:29:06 +0100	[thread overview]
Message-ID: <1759104.LDHVCAfBKo@wuerfel> (raw)
In-Reply-To: <1421036749-5308-1-git-send-email-robh@kernel.org>

On Sunday 11 January 2015 22:25:49 Rob Herring wrote:
> 
>  __invalid_entry:
>         v7m_exception_entry
> +#ifdef CONFIG_PRINTK
>         adr     r0, strerr
>         mrs     r1, ipsr
>         mov     r2, lr
>         bl      printk
> +#endif
>         mov     r0, sp
>         bl      show_regs
>  1:     b       1b
> 

Should the show_regs call be commented out as well? While
the function is still there without printk support, I believe
it doesn't actually do anything.

	Arnd

  reply	other threads:[~2015-01-12  8:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12  4:25 [PATCH] ARM: fix v7M build for !CONFIG_PRINTK Rob Herring
2015-01-12  8:29 ` Arnd Bergmann [this message]
2015-01-12 15:38   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1759104.LDHVCAfBKo@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.