From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] examples: add a new example for link reset
Date: Wed, 08 Jun 2016 11:00:01 +0200
Message-ID: <1759174.lsNpYsad2D@xps13>
References: <1465192093-28651-1-git-send-email-wenzhuo.lu@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC090903483A48@shsmsx102.ccr.corp.intel.com>
 <2601191342CEEE43887BDE71AB97725836B6CC85@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id ADC538025
 for <dev@dpdk.org>; Wed,  8 Jun 2016 11:00:02 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id v199so53531811wmv.0
 for <dev@dpdk.org>; Wed, 08 Jun 2016 02:00:02 -0700 (PDT)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B6CC85@irsmsx105.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-08 08:37, Ananyev, Konstantin:
> > From: Ananyev, Konstantin
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > > > Add a new example to show when the PF is down and up, VF port can be
> > > > reset and recover.
> > >
> > > Do we really need a totally new example for it?
> > > Can't we put it in one of already existing ones?
> > > Let say we have l3fwd-vf... wouldn't that suit your needs?
> > > Konstantin
> > I thought about just modifying an existing example. But I choose to add a new one at last. The benefit of a totally new example is we
> > can make it simple enough and focus on the reset function.
> > So it's easier for the users to find what we want to show. And it's also easier for us as we don't need to care about if our modification
> > will break some function of the original example :)
> 
> I still think that adding a new example for esch new feature/function in rte_ethdev API iw way too expensive.
> If your change is not good enough and will break original example, then you probably re-work your feature patch
> to make it stable enough.
> After all people will use it in their existing apps, not write the new ones right?
> BTW, why not make it work with testpmd?
> After all it is a new PMD api, an that's for we have our testpmd here?

+1 for testpmd