From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 3/4] uvc: don't set driver_version anymore
Date: Fri, 21 Jul 2017 13:10:52 +0300 [thread overview]
Message-ID: <1759294.240x1oprEf@avalon> (raw)
In-Reply-To: <20170721090234.6501-4-hverkuil@xs4all.nl>
Hi Hans,
Thank you for the patch.
On Friday 21 Jul 2017 11:02:33 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> This is now set by media_device_init.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c index 70842c5af05b..4f463bf2b877
> 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2096,7 +2096,6 @@ static int uvc_probe(struct usb_interface *intf,
> sizeof(dev->mdev.serial));
> strcpy(dev->mdev.bus_info, udev->devpath);
> dev->mdev.hw_revision = le16_to_cpu(udev->descriptor.bcdDevice);
> - dev->mdev.driver_version = LINUX_VERSION_CODE;
> media_device_init(&dev->mdev);
>
> dev->vdev.mdev = &dev->mdev;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-07-21 10:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 9:02 [PATCH 0/4] media: set driver_version in media_device_init Hans Verkuil
2017-07-21 9:02 ` [PATCH 1/4] media-device: " Hans Verkuil
2017-07-21 10:12 ` Laurent Pinchart
2017-07-21 10:18 ` Hans Verkuil
2017-07-21 9:02 ` [PATCH 2/4] s3c-camif: don't set driver_version anymore Hans Verkuil
2017-07-21 9:02 ` [PATCH 3/4] uvc: " Hans Verkuil
2017-07-21 10:10 ` Laurent Pinchart [this message]
2017-07-21 9:02 ` [PATCH 4/4] atomisp2: " Hans Verkuil
2017-07-21 10:10 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1759294.240x1oprEf@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.