From: David Woodhouse <dwmw2@infradead.org>
To: joakim.tjernlund@lumentis.se
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] scan.c
Date: Mon, 17 Jun 2002 23:59:13 +0100 [thread overview]
Message-ID: <17597.1024354753@redhat.com> (raw)
In-Reply-To: <IGEFJKJNHJDCBKALBJLLMEKPFEAA.joakim.tjernlund@lumentis.se>
joakim.tjernlund@lumentis.se said:
> hmm, I just save the jiffies from the beginning of
> jffs2_scan_medium() and printk the difference just before I leave that
> function.
The real kernel profiling shows a little more detail, which can sometimes
be useful. Moving the crc32 routine out of line makes it show up nicely too.
> :-), but seriously once it's on the flash, what's the probability for
> a random flipping bit?
There are other ways to screw up your flash contents. It doesn't have to be
a hardware error. I'd be a _lot_ happier if we could continue to expect
such things and deal with them.
> At mount time it will save us the trouble to CRC all the data in the
> inode's, won't it?
Yeah, but we can avoid the need to do that at mount time _anyway_. We can
probably also ditch most of build.c -- although that doesn't really seem to
be showing up very high on the profiles anyway.
--
dwmw2
prev parent reply other threads:[~2002-06-17 22:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-12 12:14 Cache mappings and invalidate Joakim Tjernlund
2001-11-12 17:44 ` Joakim Tjernlund
2001-12-17 13:08 ` Burst read and other improvements Joakim Tjernlund
2002-03-11 8:56 ` compr_zlib.c Joakim Tjernlund
2002-03-19 12:03 ` compr_zlib.c Joakim Tjernlund
2002-03-19 12:24 ` compr_zlib.c David Woodhouse
2002-01-04 8:59 ` CLEANMARKER question Joakim Tjernlund
2002-01-04 9:42 ` David Woodhouse
2002-01-04 10:33 ` Joakim Tjernlund
2002-01-04 10:41 ` David Woodhouse
2002-01-29 10:33 ` MTD/CFI probe broken? Joakim Tjernlund
2002-01-29 18:09 ` Joakim Tjernlund
2002-02-14 14:05 ` cfi_cmdset0001.c: bug fixes and new features Joakim Tjernlund
2002-02-26 13:42 ` scan.c & ACCURATE Joakim Tjernlund
2002-02-26 15:52 ` David Woodhouse
2002-02-27 7:34 ` Joakim Tjernlund
2002-02-27 8:17 ` David Woodhouse
2002-02-27 12:29 ` Joakim Tjernlund
2002-02-26 15:53 ` David Woodhouse
2002-02-27 7:43 ` Joakim Tjernlund
2002-06-17 9:24 ` point()/unpoint() questions + small cfi_cmdset_0001.c patch Joakim Tjernlund
2002-06-17 9:56 ` David Woodhouse
2002-06-17 13:37 ` David Woodhouse
2002-06-17 15:41 ` Joakim Tjernlund
2002-06-17 15:56 ` David Woodhouse
2002-06-17 16:22 ` Joakim Tjernlund
2002-06-18 14:11 ` David Woodhouse
2002-06-17 9:48 ` [PATCH] scan.c Joakim Tjernlund
2002-06-17 9:54 ` Joakim Tjernlund
2002-06-17 10:15 ` David Woodhouse
2002-06-17 12:16 ` Joakim Tjernlund
2002-06-17 12:45 ` David Woodhouse
2002-06-17 15:12 ` Joakim Tjernlund
2002-06-17 16:00 ` David Woodhouse
2002-06-17 16:51 ` Joakim Tjernlund
2002-06-17 22:59 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17597.1024354753@redhat.com \
--to=dwmw2@infradead.org \
--cc=joakim.tjernlund@lumentis.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.