From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] mk: clean up static link with DPAA libraries Date: Fri, 23 Feb 2018 10:25:57 +0100 Message-ID: <1759755.H60iFR18bq@xps> References: <1519329652.2458.5.camel@suse.de> <20180222225308.16972-2-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, mvarlese@suse.de To: Hemant Agrawal Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id C41D0288C for ; Fri, 23 Feb 2018 10:26:24 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/02/2018 07:25, Hemant Agrawal: > Hi Thomas, > On 2/23/2018 4:23 AM, Thomas Monjalon wrote: > > The bus and mempool dependencies should be declared after the PMD > > libraries needing them. > > > > Moreover there is no need to disable the PMDs at the Makefile level, > > in case the dependencies are not met. > > Such dependencies should be handled at configuration time. > > > > The other side effect of this clean-up is to take into account > > the mempool option CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL. > > > > Signed-off-by: Thomas Monjalon > > --- > > mk/rte.app.mk | 20 ++++---------------- > > 1 file changed, 4 insertions(+), 16 deletions(-) > > This patch looks good, however I think we (NXP) need to also set some > dependency check in makefile to avoid dpaaX PMD compilations, if bus is > not available. I am working on a patch for the same. Why do you think such check is necessary? If the PMD is enable but not the bus, it is a configuration error. A good configuration system would resolve it automatically, but currently we do the configuration manually, so the user must fix its configuration file.